Skip to content

Conversation

devin-ai-integration[bot]
Copy link
Contributor

fix: update onnxruntime dependency to >=1.22.1 for Windows Server 2019 compatibility

Summary

Updates the onnxruntime dependency constraint from ==1.22.0 to >=1.22.1 to resolve a DLL load failure bug affecting Windows Server 2019. This is a minimal dependency version update that addresses issue #3398.

Changes:

  • Updated onnxruntime constraint in pyproject.toml from ==1.22.0 to >=1.22.1
  • Added version verification test in tests/test_imports.py to ensure onnxruntime >= 1.22.1
  • Added comprehensive tests for ONNX embedding functionality in tests/rag/test_embeddings_factory.py
  • Updated uv.lock with new dependency resolution (onnxruntime updated from 1.19.2 to 1.22.1)

Review & Testing Checklist for Human

2 items - This is a low-risk dependency version update with targeted testing

  • Test ONNX embedding functionality - Verify that the RAG embedding factory with ONNX provider still works correctly after the onnxruntime update
  • Verify Windows Server 2019 compatibility - If possible, test on Windows Server 2019 to confirm the DLL load failure issue is resolved (this was the original issue)

Notes

  • The dependency update is minimal and conservative - only allows versions >= 1.22.1 rather than unrestricted updates
  • All new tests pass locally, confirming onnxruntime can be imported and ONNX embeddings work correctly
  • The full test suite had many failures, but they appear to be authentication/connection issues with external services, not related to this dependency change
  • Original issue: Windows Server 2019 users experienced DLL load failures with onnxruntime 1.22.0

Link to Devin run: https://app.devin.ai/sessions/00ba8c9ae67f4772b94f3c6018ec2d67
Requested by: João ([email protected])

Resolves: #3398

…9 compatibility

- Update onnxruntime constraint from ==1.22.0 to >=1.22.1 in pyproject.toml
- Add test to verify onnxruntime version constraint in test_imports.py
- Add comprehensive tests for ONNX embedding functionality
- Fixes issue #3398 where onnxruntime 1.22.0 causes DLL load failures on Windows Server 2019

Resolves: #3398
Co-Authored-By: João <[email protected]>
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Copy link
Contributor Author

Closing due to inactivity for more than 7 days. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants