Fix opentelemetry protobuf dependency conflict with Google Cloud SDKs #3414
+3,449
−3,718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
…loud SDKs - Downgrade opentelemetry requirements from >=1.30.0 to >=1.27.0,<1.28.0 - This resolves protobuf version conflict where opentelemetry 1.30.0+ requires protobuf>=5.0 but Google Cloud SDKs require protobuf<5.0 - Now uses protobuf 4.25.8 which satisfies both requirements - Add comprehensive dependency compatibility tests - Fixes issue #3413 Co-Authored-By: João <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
- Remove unused imports: pathlib.Path, opentelemetry modules - Remove unused variable assignment for context - All ruff checks now pass locally Co-Authored-By: João <[email protected]>
|
Closing due to inactivity for more than 7 days. Configure here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix opentelemetry protobuf dependency conflict with Google Cloud SDKs
Summary
Resolves issue #3413 by downgrading OpenTelemetry requirements from
>=1.30.0to>=1.27.0,<1.28.0. This fixes a dependency conflict where OpenTelemetry 1.30.0+ requiresprotobuf>=5.0, but Google Cloud SDKs requireprotobuf<5.0.The solution constrains OpenTelemetry to version 1.27.x which uses
protobuf<5.0,>=3.19, allowing both CrewAI and Google Cloud SDKs to coexist. After the change, protobuf resolves to version 4.25.8 which satisfies both requirements.Changes:
pyproject.tomlto constrain opentelemetry packages to>=1.27.0,<1.28.0uv.lockwith compatible dependency resolutionReview & Testing Checklist for Human
This is a YELLOW risk change - dependency downgrades require careful validation:
google-cloud-storage,google-cloud-bigquery) alongside CrewAI to confirm the protobuf conflict is resolveduv run pytest tests -vto ensure no regressionsNotes
<1.28.0may be overly restrictive - consider if 1.28.x/1.29.x could be allowed in future updatestest_opentelemetry_fix.pysuccessfully verified the fix resolves protobuf to 4.25.8Requested by: João ([email protected])
Devin session: https://app.devin.ai/sessions/18608f05b924444298bfb15d24d3d1c0