Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: Can not query walletconnect status (fix #257) #258

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

damoncro
Copy link
Contributor

@damoncro damoncro commented Feb 6, 2023

Close:

Solutions:

  • Add internal _session_info and remove const
  • Add public function: GetWalletConnectSessionInfo

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

Thank you for your code, it's appreciated! :)

@damoncro damoncro requested a review from a team as a code owner February 6, 2023 03:41
Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thread-safety is ok?

@damoncro
Copy link
Contributor Author

damoncro commented Feb 6, 2023

thread-safety is ok?

It should be fine, without the AsynTask, OnReceiveWalletconnectSessionInfoDelegate could be called in GameThread correctly (AysncTask and run it in GameThread is redundant).

@tomtau tomtau requested a review from leejw51crypto February 7, 2023 02:25
@tomtau
Copy link
Contributor

tomtau commented Feb 7, 2023

maybe ok, but for the UE concurrency better for @leejw51crypto to check

@damoncro damoncro changed the title Problem: Can not query walletconnect status (fix #214, #257) Problem: Can not query walletconnect status (fix #257) Feb 8, 2023
@damoncro damoncro force-pushed the bug/walletconnect_status_check branch from 4853619 to fd6e752 Compare February 8, 2023 04:56
Close:
- #257

Solutions:
- Add internal _session_info and remove const
- Add public function: GetWalletConnectSessionInfo
@damoncro damoncro force-pushed the bug/walletconnect_status_check branch from fd6e752 to f8670cf Compare February 8, 2023 05:22
Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, the potential concurrency issues may be revisited in a follow up PR

@leejw51crypto leejw51crypto merged commit 8426baa into main Feb 8, 2023
@tomtau tomtau deleted the bug/walletconnect_status_check branch February 9, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants