Add desired state changed event filter to all controllers (#498)

pkg/controller/cache/managed.go

@@ -77,6 +77,7 @@ func SetupCloudMemorystoreInstance(mgr ctrl.Manager, o controller.Options) error
 	return ctrl.NewControllerManagedBy(mgr).
 		Named(name).
 		WithOptions(o.ForControllerRuntime()).
+		WithEventFilter(resource.DesiredStateChanged()).
 		For(&v1beta1.CloudMemorystoreInstance{}).
 		Complete(ratelimiter.NewReconciler(name, r, o.GlobalRateLimiter))
 }

pkg/controller/compute/address.go

@@ -71,6 +71,7 @@ func SetupAddress(mgr ctrl.Manager, o controller.Options) error {
 	return ctrl.NewControllerManagedBy(mgr).
 		Named(name).
 		WithOptions(o.ForControllerRuntime()).
+		WithEventFilter(resource.DesiredStateChanged()).
 		For(&v1beta1.Address{}).
 		Complete(ratelimiter.NewReconciler(name, r, o.GlobalRateLimiter))
 }

pkg/controller/compute/firewall.go

@@ -73,6 +73,7 @@ func SetupFirewall(mgr ctrl.Manager, o controller.Options) error {
 	return ctrl.NewControllerManagedBy(mgr).
 		Named(name).
 		WithOptions(o.ForControllerRuntime()).
+		WithEventFilter(resource.DesiredStateChanged()).
 		For(&v1alpha1.Firewall{}).
 		Complete(ratelimiter.NewReconciler(name, r, o.GlobalRateLimiter))
 }

pkg/controller/compute/globaladdress.go

@@ -72,6 +72,7 @@ func SetupGlobalAddress(mgr ctrl.Manager, o controller.Options) error {
 	return ctrl.NewControllerManagedBy(mgr).
 		Named(name).
 		WithOptions(o.ForControllerRuntime()).
+		WithEventFilter(resource.DesiredStateChanged()).
 		For(&v1beta1.GlobalAddress{}).
 		Complete(ratelimiter.NewReconciler(name, r, o.GlobalRateLimiter))
 }

pkg/controller/compute/network.go

@@ -76,6 +76,7 @@ func SetupNetwork(mgr ctrl.Manager, o controller.Options) error {
 	return ctrl.NewControllerManagedBy(mgr).
 		Named(name).
 		WithOptions(o.ForControllerRuntime()).
+		WithEventFilter(resource.DesiredStateChanged()).
 		For(&v1beta1.Network{}).
 		Complete(ratelimiter.NewReconciler(name, r, o.GlobalRateLimiter))
 }

pkg/controller/compute/router.go

@@ -72,6 +72,7 @@ func SetupRouter(mgr ctrl.Manager, o controller.Options) error {
 	return ctrl.NewControllerManagedBy(mgr).
 		Named(name).
 		WithOptions(o.ForControllerRuntime()).
+		WithEventFilter(resource.DesiredStateChanged()).
 		For(&v1alpha1.Router{}).
 		Complete(ratelimiter.NewReconciler(name, r, o.GlobalRateLimiter))
 }

pkg/controller/compute/subnetwork.go

@@ -76,6 +76,7 @@ func SetupSubnetwork(mgr ctrl.Manager, o controller.Options) error {
 	return ctrl.NewControllerManagedBy(mgr).
 		Named(name).
 		WithOptions(o.ForControllerRuntime()).
+		WithEventFilter(resource.DesiredStateChanged()).
 		For(&v1beta1.Subnetwork{}).
 		Complete(ratelimiter.NewReconciler(name, r, o.GlobalRateLimiter))
 }

pkg/controller/config/config.go

@@ -46,6 +46,7 @@ func Setup(mgr ctrl.Manager, o controller.Options) error {
 	return ctrl.NewControllerManagedBy(mgr).
 		Named(name).
 		WithOptions(o.ForControllerRuntime()).
+		WithEventFilter(resource.DesiredStateChanged()).
 		For(&v1beta1.ProviderConfig{}).
 		Watches(&source.Kind{Type: &v1beta1.ProviderConfigUsage{}}, &resource.EnqueueRequestForProviderConfig{}).
 		Complete(ratelimiter.NewReconciler(name, r, o.GlobalRateLimiter))

pkg/controller/container/cluster.go

@@ -75,6 +75,7 @@ func SetupCluster(mgr ctrl.Manager, o controller.Options) error {
 	return ctrl.NewControllerManagedBy(mgr).
 		Named(name).
 		WithOptions(o.ForControllerRuntime()).
+		WithEventFilter(resource.DesiredStateChanged()).
 		For(&v1beta2.Cluster{}).
 		Complete(ratelimiter.NewReconciler(name, r, o.GlobalRateLimiter))
 }

pkg/controller/container/nodepool.go

@@ -73,6 +73,7 @@ func SetupNodePool(mgr ctrl.Manager, o controller.Options) error {
 	return ctrl.NewControllerManagedBy(mgr).
 		Named(name).
 		WithOptions(o.ForControllerRuntime()).
+		WithEventFilter(resource.DesiredStateChanged()).
 		For(&v1beta1.NodePool{}).
 		Complete(ratelimiter.NewReconciler(name, r, o.GlobalRateLimiter))
 }

pkg/controller/database/cloudsql.go

@@ -79,6 +79,7 @@ func SetupCloudSQLInstance(mgr ctrl.Manager, o controller.Options) error {
 	return ctrl.NewControllerManagedBy(mgr).
 		Named(name).
 		WithOptions(o.ForControllerRuntime()).
+		WithEventFilter(resource.DesiredStateChanged()).
 		For(&v1beta1.CloudSQLInstance{}).
 		Complete(ratelimiter.NewReconciler(name, r, o.GlobalRateLimiter))
 }

pkg/controller/dns/policy.go

@@ -70,6 +70,7 @@ func SetupPolicy(mgr ctrl.Manager, o controller.Options) error {
 	return ctrl.NewControllerManagedBy(mgr).
 		Named(name).
 		WithOptions(o.ForControllerRuntime()).
+		WithEventFilter(resource.DesiredStateChanged()).
 		For(&v1alpha1.Policy{}).
 		Complete(ratelimiter.NewReconciler(name, r, o.GlobalRateLimiter))
 }

pkg/controller/dns/resource_record_set.go

@@ -73,6 +73,7 @@ func SetupResourceRecordSet(mgr ctrl.Manager, o controller.Options) error {
 	return ctrl.NewControllerManagedBy(mgr).
 		Named(name).
 		WithOptions(o.ForControllerRuntime()).
+		WithEventFilter(resource.DesiredStateChanged()).
 		For(&v1alpha1.ResourceRecordSet{}).
 		Complete(ratelimiter.NewReconciler(name, r, o.GlobalRateLimiter))
 }

pkg/controller/iam/serviceaccount.go

@@ -71,6 +71,7 @@ func SetupServiceAccount(mgr ctrl.Manager, o controller.Options) error {
 	return ctrl.NewControllerManagedBy(mgr).
 		Named(name).
 		WithOptions(o.ForControllerRuntime()).
+		WithEventFilter(resource.DesiredStateChanged()).
 		For(&v1alpha1.ServiceAccount{}).
 		Complete(ratelimiter.NewReconciler(name, r, o.GlobalRateLimiter))
 }

pkg/controller/iam/serviceaccountkey.go

@@ -86,6 +86,7 @@ func SetupServiceAccountKey(mgr ctrl.Manager, o controller.Options) error {
 	return ctrl.NewControllerManagedBy(mgr).
 		Named(name).
 		WithOptions(o.ForControllerRuntime()).
+		WithEventFilter(resource.DesiredStateChanged()).
 		For(&v1alpha1.ServiceAccountKey{}).
 		Complete(ratelimiter.NewReconciler(name, r, o.GlobalRateLimiter))
 }

pkg/controller/iam/serviceaccountpolicy.go

@@ -67,6 +67,7 @@ func SetupServiceAccountPolicy(mgr ctrl.Manager, o controller.Options) error {
 	return ctrl.NewControllerManagedBy(mgr).
 		Named(name).
 		WithOptions(o.ForControllerRuntime()).
+		WithEventFilter(resource.DesiredStateChanged()).
 		For(&v1alpha1.ServiceAccountPolicy{}).
 		Complete(ratelimiter.NewReconciler(name, r, o.GlobalRateLimiter))
 }

pkg/controller/kms/cryptokey.go

@@ -67,6 +67,7 @@ func SetupCryptoKey(mgr ctrl.Manager, o controller.Options) error {
 	return ctrl.NewControllerManagedBy(mgr).
 		Named(name).
 		WithOptions(o.ForControllerRuntime()).
+		WithEventFilter(resource.DesiredStateChanged()).
 		For(&v1alpha1.CryptoKey{}).
 		Complete(ratelimiter.NewReconciler(name, r, o.GlobalRateLimiter))
 }

pkg/controller/kms/cryptokeypolicy.go

@@ -66,6 +66,7 @@ func SetupCryptoKeyPolicy(mgr ctrl.Manager, o controller.Options) error {
 	return ctrl.NewControllerManagedBy(mgr).
 		Named(name).
 		WithOptions(o.ForControllerRuntime()).
+		WithEventFilter(resource.DesiredStateChanged()).
 		For(&v1alpha1.CryptoKeyPolicy{}).
 		Complete(ratelimiter.NewReconciler(name, r, o.GlobalRateLimiter))
 }

pkg/controller/kms/keyring.go

@@ -70,6 +70,7 @@ func SetupKeyRing(mgr ctrl.Manager, o controller.Options) error {
 	return ctrl.NewControllerManagedBy(mgr).
 		Named(name).
 		WithOptions(o.ForControllerRuntime()).
+		WithEventFilter(resource.DesiredStateChanged()).
 		For(&v1alpha1.KeyRing{}).
 		Complete(ratelimiter.NewReconciler(name, r, o.GlobalRateLimiter))
 }

pkg/controller/pubsub/subscription.go

@@ -70,6 +70,7 @@ func SetupSubscription(mgr ctrl.Manager, o controller.Options) error {
 	return ctrl.NewControllerManagedBy(mgr).
 		Named(name).
 		WithOptions(o.ForControllerRuntime()).
+		WithEventFilter(resource.DesiredStateChanged()).
 		For(&v1alpha1.Subscription{}).
 		Complete(ratelimiter.NewReconciler(name, r, o.GlobalRateLimiter))
 }

pkg/controller/pubsub/topic.go

@@ -71,6 +71,7 @@ func SetupTopic(mgr ctrl.Manager, o controller.Options) error {
 	return ctrl.NewControllerManagedBy(mgr).
 		Named(name).
 		WithOptions(o.ForControllerRuntime()).
+		WithEventFilter(resource.DesiredStateChanged()).
 		For(&v1alpha1.Topic{}).
 		Complete(ratelimiter.NewReconciler(name, r, o.GlobalRateLimiter))
 }

pkg/controller/registry/containerregistry.go

@@ -78,6 +78,7 @@ func SetupContainerRegistry(mgr ctrl.Manager, o controller.Options) error {
 	return ctrl.NewControllerManagedBy(mgr).
 		Named(name).
 		WithOptions(o.ForControllerRuntime()).
+		WithEventFilter(resource.DesiredStateChanged()).
 		For(&v1alpha1.ContainerRegistry{}).
 		Complete(ratelimiter.NewReconciler(name, r, o.GlobalRateLimiter))
 }

pkg/controller/servicenetworking/connection.go

@@ -96,6 +96,7 @@ func SetupConnection(mgr ctrl.Manager, o controller.Options) error {
 	return ctrl.NewControllerManagedBy(mgr).
 		Named(name).
 		WithOptions(o.ForControllerRuntime()).
+		WithEventFilter(resource.DesiredStateChanged()).
 		For(&v1beta1.Connection{}).
 		Complete(ratelimiter.NewReconciler(name, r, o.GlobalRateLimiter))
 }

pkg/controller/storage/bucket.go

@@ -72,6 +72,7 @@ func SetupBucket(mgr ctrl.Manager, o controller.Options) error {
 	return ctrl.NewControllerManagedBy(mgr).
 		Named(name).
 		WithOptions(o.ForControllerRuntime()).
+		WithEventFilter(resource.DesiredStateChanged()).
 		For(&v1alpha3.Bucket{}).
 		Complete(ratelimiter.NewReconciler(name, r, o.GlobalRateLimiter))
 }

pkg/controller/storage/bucketpolicy.go

@@ -68,6 +68,7 @@ func SetupBucketPolicy(mgr ctrl.Manager, o controller.Options) error {
 	return ctrl.NewControllerManagedBy(mgr).
 		Named(name).
 		WithOptions(o.ForControllerRuntime()).
+		WithEventFilter(resource.DesiredStateChanged()).
 		For(&v1alpha1.BucketPolicy{}).
 		Complete(ratelimiter.NewReconciler(name, r, o.GlobalRateLimiter))
 }

pkg/controller/storage/bucketpolicymember.go

@@ -64,6 +64,7 @@ func SetupBucketPolicyMember(mgr ctrl.Manager, o controller.Options) error {
 	return ctrl.NewControllerManagedBy(mgr).
 		Named(name).
 		WithOptions(o.ForControllerRuntime()).
+		WithEventFilter(resource.DesiredStateChanged()).
 		For(&v1alpha1.BucketPolicyMember{}).
 		Complete(ratelimiter.NewReconciler(name, r, o.GlobalRateLimiter))
 }