feat: Allow multiple ref types for clientID & clientScopeId #311
+1,413
−311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dennis Kniep <[email protected]>
denniskniep
force-pushed
the
feature/multi-type-for-refs
branch
from
a6d2855 to
e6de6b2
Compare
Collaborator
Author
|
Created a RC release for testing: |
Collaborator
|
@denniskniep can you move your branch into this repository? That should work as you are maintainer as well, then i can probably start to rebase |
Collaborator
Author
Collaborator
Author
|
We need to change the API and therefore implement another version of the CRD: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #88 #394
As Ref: crossplane/crossplane-runtime#834