Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support additional management policy combination #788

Conversation

man-ish-k
Copy link
Contributor

Description of your changes

Add two new management policy combinations to support safer resource importing and external lifecycle management scenarios:

  1. Import Mode: A new policy combination that allows safe importing of existing resources by only permitting observation and late initialization, without making any changes to the external resource.

    • Actions: [Observe, LateInitialize]
    • Use case: Safely discover and import existing cloud resources into Crossplane without risk of modifying them
  2. External Lifecycle Management: A policy combination for resources whose lifecycle (creation/deletion) is managed outside of Crossplane, but allows Crossplane to make updates and track state.

    • Actions: [Observe, Update, LateInitialize]
    • Use case: Integration with external provisioning systems while maintaining Crossplane's ability to manage resource configuration

Fixes #681,

I have:

Need help with this checklist? See the cheat sheet.

@man-ish-k man-ish-k requested a review from a team as a code owner November 10, 2024 08:38
@man-ish-k man-ish-k requested a review from negz November 10, 2024 08:38
@man-ish-k man-ish-k force-pushed the feat-additional-management-policy-combination branch from dc9fcb1 to 32db6df Compare November 10, 2024 08:39
@jake-ciolek
Copy link

Hi @jbw976 and @negz . Could you please have a look at this one? It's been open for a while. Thanks!

Copy link
Contributor

@lsviben lsviben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Firstly, sorry for waiting that long for a review, this slipped my mind and I got reminded just recently 🙏 .

The policies added make sense to me.

We need to add the unit tests in the right place to check the reconciler flow with the new policies.

Signed-off-by: Manish Kumar <[email protected]>
@man-ish-k man-ish-k requested a review from lsviben February 23, 2025 10:48
Copy link
Contributor

@lsviben lsviben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @man-ish-k ! 🎉

@turkenh turkenh merged commit 5faceb9 into crossplane:main Feb 25, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support "Update" without "Create" management policy combinations
4 participants