Skip to content

chore(deps): update dependency golangci/golangci-lint to v2.7.2 (main) #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
crossplane-renovate wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(deps): update dependency golangci/golangci-lint to v2.7.2 (main) #891

crossplane-renovate wants to merge 1 commit into from
+1 −1

Conversation

@crossplane-renovate
Copy link
Contributor

@crossplane-renovate crossplane-renovate bot commented Nov 27, 2025 •
edited
Loading

This PR contains the following updates:

Package Update Change
golangci/golangci-lint minor v2.2.1 -> v2.7.2

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

Release Notes

golangci/golangci-lint (golangci/golangci-lint)

v2.7.2

Compare Source

Released on 2025-12-07

  1. Linter bug fixes

v2.7.1

Compare Source

Released on 2025-12-04

  1. Linter bug fixes
    • modernize: disable stringscut analyzer

v2.7.0

Compare Source

Released on 2025-12-03

  1. Bug fixes
    • fix: clone args used by custom command
  2. Linters new features or changes
    • no-sprintf-host-port: from 0.2.0 to 0.3.1 (ignore string literals without a colon)
    • unqueryvet: from 1.2.1 to 1.3.0 (handles const and var declarations)
    • revive: from 1.12.0 to 1.13.0 (new option: enable-default-rules, new rules: forbidden-call-in-wg-go, unnecessary-if, inefficient-map-lookup)
    • modernize: from 0.38.0 to 0.39.0 (new analyzers: plusbuild, stringscut)
  3. Linters bug fixes
    • perfsprint: from 0.10.0 to 0.10.1
    • wrapcheck: from 2.11.0 to 2.12.0
    • godoc-lint: from 0.10.1 to 0.10.2
  4. Misc.
    • Add some flags to the custom command
  5. Documentation
    • docs: split changelog v1 and v2

v2.6.2

Compare Source

Released on 2025-11-14

  1. Bug fixes
    • fmt command with symlinks
    • use file depending on build configuration to invalidate cache
  2. Linters bug fixes
    • testableexamples: from 1.0.0 to 1.0.1
    • testpackage: from 1.1.1 to 1.1.2

v2.6.1

Compare Source

Released on 2025-11-04

  1. Linters bug fixes
    • copyloopvar: from 1.2.1 to 1.2.2
    • go-critic: from 0.14.0 to 0.14.2

v2.6.0

Compare Source

Released on 2025-10-29

  1. New linters
    • Add modernize analyzer suite
  2. Linters new features or changes
    • arangolint: from 0.2.0 to 0.3.1
    • dupword: from 0.1.6 to 0.1.7 (new option comments-only)
    • go-critic: from 0.13.0 to 0.14.0 (new rules/checkers: zeroByteRepeat, dupOption)
    • gofumpt: from 0.9.1 to 0.9.2 ("clothe" naked returns is now controlled by the extra-rules option)
    • perfsprint: from 0.9.1 to 0.10.0 (new options: concat-loop, loop-other-ops)
    • wsl: from 5.2.0 to 5.3.0
  3. Linters bug fixes
    • dupword: from 0.1.6 to 0.1.7
    • durationcheck: from 0.0.10 to 0.0.11
    • exptostd: from 0.4.4 to 0.4.5
    • fatcontext: from 0.8.1 to 0.9.0
    • forbidigo: from 2.1.0 to 2.3.0
    • ginkgolinter: from 0.21.0 to 0.21.2
    • godoc-lint: from 0.10.0 to 0.10.1
    • gomoddirectives: from 0.7.0 to 0.7.1
    • gosec: from 2.22.8 to 2.22.10
    • makezero: from 2.0.1 to 2.1.0
    • nilerr: from 0.1.1 to 0.1.2
    • paralleltest: from 1.0.14 to 1.0.15
    • protogetter: from 0.3.16 to 0.3.17
    • unparam: from 0df0534 to 5beb8c8
  4. Misc.
    • fix: ignore some files to hash the version for custom build

v2.5.0

Compare Source

Released on 2025-09-21

  1. New linters
  2. Linters new features or changes
    • embeddedstructfieldcheck: from 0.3.0 to 0.4.0 (new option: empty-line)
    • err113: from aea10b5 to 0.1.1 (skip internals of Is methods for error type)
    • ginkgolinter: from 0.20.0 to 0.21.0 (new option: force-tonot)
    • gofumpt: from 0.8.0 to 0.9.1 (new rule is to "clothe" naked returns for the sake of clarity)
    • ineffassign: from 0.1.0 to 0.2.0 (new option: check-escaping-errors)
    • musttag: from 0.13.1 to 0.14.0 (support interface methods)
    • revive: from 1.11.0 to 1.12.0 (new options: identical-ifelseif-branches, identical-ifelseif-conditions, identical-switch-branches, identical-switch-conditions, package-directory-mismatch, unsecure-url-scheme, use-waitgroup-go, useless-fallthrough)
    • thelper: from 0.6.3 to 0.7.1 (skip t.Helper in functions passed to synctest.Test)
    • wsl: from 5.1.1 to 5.2.0 (improvements related to subexpressions)
  3. Linters bug fixes
    • asciicheck: from 0.4.1 to 0.5.0
    • errname: from 1.1.0 to 1.1.1
    • fatcontext: from 0.8.0 to 0.8.1
    • go-printf-func-name: from 0.1.0 to 0.1.1
    • godot: from 1.5.1 to 1.5.4
    • gosec: from 2.22.7 to 2.22.8
    • nilerr: from 0.1.1 to a temporary fork
    • nilnil: from 1.1.0 to 1.1.1
    • protogetter: from 0.3.15 to 0.3.16
    • tagliatelle: from 0.7.1 to 0.7.2
    • testifylint: from 1.6.1 to 1.6.4
  4. Misc.
    • fix: "no export data" errors are now handled as a standard typecheck error
  5. Documentation
    • Improve nolint section about syntax

v2.4.0

Compare Source

Released on 2025-08-14

  1. Enhancements
    • 🎉 go1.25 support
  2. Linters new features or changes
    • exhaustruct: from v3.3.1 to 4.0.0 (new options: allow-empty, allow-empty-rx, allow-empty-returns, allow-empty-declarations)
  3. Linters bug fixes
    • godox: trim filepath from report messages
    • staticcheck: allow empty options
    • tagalign: from 1.4.2 to 1.4.3
  4. Documentation
    • 🌟 New website (with a search engine)

v2.3.1

Compare Source

Released on 2025-08-02

  1. Linters bug fixes
    • gci: from 0.13.6 to 0.13.7
    • gosec: from 2.22.6 to 2.22.7
    • noctx: from 0.3.5 to 0.4.0
    • wsl: from 5.1.0 to 5.1.1
    • tagliatelle: force upper case for custom initialisms

v2.3.0

Compare Source

Released on 2025-07-21

  1. Linters new features or changes
    • ginkgolinter: from 0.19.1 to 0.20.0 (new option: force-assertion-description)
    • iface: from 1.4.0 to 1.4.1 (report message improvements)
    • noctx: from 0.3.4 to 0.3.5 (new detections: log/slog, exec, crypto/tls)
    • revive: from 1.10.0 to 1.11.0 (new rule: enforce-switch-style)
    • wsl: from 5.0.0 to 5.1.0
  2. Linters bug fixes
    • gosec: from 2.22.5 to 2.22.6
    • noinlineerr: from 1.0.4 to 1.0.5
    • sloglint: from 0.11.0 to 0.11.1
  3. Misc.
    • fix: panic close of closed channel

v2.2.2

Compare Source

Released on 2025-07-11

  1. Linters bug fixes
    • noinlineerr: from 1.0.3 to 1.0.4
  2. Documentation
    • Improve debug keys documentation
  3. Misc.
    • fix: panic close of closed channel
    • godot: add noinline value into the JSONSchema

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@crossplane-renovate crossplane-renovate bot requested a review from a team as a code owner November 27, 2025 08:08
@crossplane-renovate crossplane-renovate bot requested a review from bobh66 November 27, 2025 08:08
@crossplane-renovate
Copy link
Contributor Author

crossplane-renovate bot commented Nov 27, 2025 •
edited
Loading

⚠️ Artifact update problem

Renovate failed to update artifacts related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: Earthfile
Command failed: earthly --strict +go-lint
 Init 🚀
————————————————————————————————————————————————————————————————————————————————

           buildkitd | Found buildkit daemon as docker container (earthly-buildkitd)

 Build 🔧
————————————————————————————————————————————————————————————————————————————————

            +go-lint | --> FROM +base
            +go-lint | --> FROM +go-modules
         +go-modules | --> FROM +base
       golang:1.24.4 | --> Load metadata golang:1.24.4 linux/amd64
Warning: you are not logged into registry-1.docker.io, you may experience rate-limitting when pulling images
         +go-modules | --> FROM golang:1.24.4
         +go-modules | [----------] 100% FROM golang:1.24.4�[K
         +go-modules | [          ]   0% FROM golang:1.24.4�[K
         +go-modules | �[A[----------] 100% FROM golang:1.24.4�[K
         +go-modules | --> WORKDIR /crossplane
         +go-modules | --> COPY go.mod go.sum ./
         +go-modules | --> RUN go mod download
            +go-lint | --> RUN curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin ${GOLANGCI_LINT_VERSION}
            +go-lint | golangci/golangci-lint info checking GitHub for tag 'v2.7.2'
            +go-lint | golangci/golangci-lint info found version: 2.7.2 for v2.7.2/linux/amd64
            +go-lint | golangci/golangci-lint info installed /go/bin/golangci-lint
            +go-lint | --> COPY .golangci.yml .
            +go-lint | --> COPY --dir apis/ pkg/ .
            +go-lint | --> RUN golangci-lint run --fix
            +go-lint | pkg/meta/meta.go:68:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint | // Deprecated: use a more specific reference type, such as TypedReference or
            +go-lint | ^
            +go-lint | pkg/reconciler/managed/policies.go:37:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint | // Deprecated: this is for LegacyManaged types, that had deletion policy.
            +go-lint | ^
            +go-lint | pkg/reconciler/managed/policies.go:132:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint | // Deprecated: this is intended for LegacyManaged resources that had deletionPolicy
            +go-lint | ^
            +go-lint | pkg/reconciler/managed/reconciler_deprecated.go:26:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint | // Deprecated: use ExternalConnector.
            +go-lint | ^
            +go-lint | pkg/reconciler/managed/reconciler_deprecated.go:30:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint | // Deprecated: use TypedExternalConnector.
            +go-lint | ^
            +go-lint | pkg/reconciler/managed/reconciler_deprecated.go:57:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint | // Deprecated: Use NopDisconnector.
            +go-lint | ^
            +go-lint | pkg/reconciler/managed/reconciler_deprecated.go:66:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint | // Deprecated: use NewNopDisconnector.
            +go-lint | ^
            +go-lint | pkg/reconciler/managed/reconciler_deprecated.go:72:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint | // Deprecated: use ExternalDisconnectorFn.
            +go-lint | ^
            +go-lint | pkg/reconciler/managed/reconciler_deprecated.go:76:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint | // Deprecated: use ExternalConnectDisconnectorFns.
            +go-lint | ^
            +go-lint | pkg/reconciler/managed/reconciler_deprecated.go:80:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint | // Deprecated: use NopConnector.
            +go-lint | ^
            +go-lint | pkg/reconciler/managed/reconciler_deprecated.go:84:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint | // Deprecated: use WithExternalConnector.
            +go-lint | ^
            +go-lint | pkg/reconciler/managed/reconciler_deprecated.go:100:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint | // Deprecated: Please use Disconnect() on the ExternalClient for disconnecting from the provider.
            +go-lint | ^
            +go-lint | pkg/reconciler/managed/reconciler_deprecated.go:118:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint | // Deprecated: Please use Disconnect() on the ExternalClient for disconnecting from the provider.
            +go-lint | ^
            +go-lint | pkg/resource/interfaces.go:218:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint | // Deprecated: new namespace-scoped MRs should implement ModernManaged.
            +go-lint | ^
            +go-lint | pkg/resource/interfaces.go:235:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint | // Deprecated: new types should implement ManagedList.
            +go-lint | ^
            +go-lint | pkg/resource/interfaces.go:266:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint | // Deprecated: new PCUs should implement TypedProviderConfigUsage.
            +go-lint | ^
            +go-lint | pkg/resource/predicates.go:28:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint | // Deprecated: This type will be removed soon. Please use
            +go-lint | ^
            +go-lint | pkg/resource/predicates.go:34:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint | // Deprecated: This function will be removed soon. Please use
            +go-lint | ^
            +go-lint | pkg/event/event.go:17:1: package has more than one godoc ("event") (godoclint)
            +go-lint | 23 issues:
            +go-lint | * gocritic: 18
            +go-lint | * godoclint: 4
            +go-lint | * revive: 1
            +go-lint | // Package event records Kubernetes events.
            +go-lint | ^
            +go-lint | pkg/event/event_test.go:17:1: package has more than one godoc ("event") (godoclint)
            +go-lint | // Package event records Kubernetes events.
            +go-lint | ^
            +go-lint | pkg/reference/namespaced_reference.go:17:1: package has more than one godoc ("reference") (godoclint)
            +go-lint | // Package reference contains utilities for working with cross-resource
            +go-lint | ^
            +go-lint | pkg/reference/reference.go:17:1: package has more than one godoc ("reference") (godoclint)
            +go-lint | // Package reference contains utilities for working with cross-resource
            +go-lint | ^
            +go-lint | pkg/errors/reconcile_test.go:17:9: var-naming: avoid package names that conflict with Go standard library package names (revive)
            +go-lint | package errors
            +go-lint |         ^
            +go-lint | ERROR Earthfile:113:2
            +go-lint |       The command
            +go-lint |           RUN golangci-lint run --fix
            +go-lint |       did not complete successfully. Exit code 1

================================== ❌ FAILURE ===================================

            +go-lint *failed* | Repeating the failure error...
            +go-lint *failed* | --> RUN golangci-lint run --fix
            +go-lint *failed* | pkg/meta/meta.go:68:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint *failed* | // Deprecated: use a more specific reference type, such as TypedReference or
            +go-lint *failed* | ^
            +go-lint *failed* | pkg/reconciler/managed/policies.go:37:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint *failed* | // Deprecated: this is for LegacyManaged types, that had deletion policy.
            +go-lint *failed* | ^
            +go-lint *failed* | pkg/reconciler/managed/policies.go:132:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint *failed* | // Deprecated: this is intended for LegacyManaged resources that had deletionPolicy
            +go-lint *failed* | ^
            +go-lint *failed* | pkg/reconciler/managed/reconciler_deprecated.go:26:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint *failed* | // Deprecated: use ExternalConnector.
            +go-lint *failed* | ^
            +go-lint *failed* | pkg/reconciler/managed/reconciler_deprecated.go:30:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint *failed* | // Deprecated: use TypedExternalConnector.
            +go-lint *failed* | ^
            +go-lint *failed* | pkg/reconciler/managed/reconciler_deprecated.go:57:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint *failed* | // Deprecated: Use NopDisconnector.
            +go-lint *failed* | ^
            +go-lint *failed* | pkg/reconciler/managed/reconciler_deprecated.go:66:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint *failed* | // Deprecated: use NewNopDisconnector.
            +go-lint *failed* | ^
            +go-lint *failed* | pkg/reconciler/managed/reconciler_deprecated.go:72:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint *failed* | // Deprecated: use ExternalDisconnectorFn.
            +go-lint *failed* | ^
            +go-lint *failed* | pkg/reconciler/managed/reconciler_deprecated.go:76:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint *failed* | // Deprecated: use ExternalConnectDisconnectorFns.
            +go-lint *failed* | ^
            +go-lint *failed* | pkg/reconciler/managed/reconciler_deprecated.go:80:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint *failed* | // Deprecated: use NopConnector.
            +go-lint *failed* | ^
            +go-lint *failed* | pkg/reconciler/managed/reconciler_deprecated.go:84:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint *failed* | // Deprecated: use WithExternalConnector.
            +go-lint *failed* | ^
            +go-lint *failed* | pkg/reconciler/managed/reconciler_deprecated.go:100:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint *failed* | // Deprecated: Please use Disconnect() on the ExternalClient for disconnecting from the provider.
            +go-lint *failed* | ^
            +go-lint *failed* | pkg/reconciler/managed/reconciler_deprecated.go:118:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint *failed* | // Deprecated: Please use Disconnect() on the ExternalClient for disconnecting from the provider.
            +go-lint *failed* | ^
            +go-lint *failed* | pkg/resource/interfaces.go:218:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint *failed* | // Deprecated: new namespace-scoped MRs should implement ModernManaged.
            +go-lint *failed* | ^
            +go-lint *failed* | pkg/resource/interfaces.go:235:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint *failed* | // Deprecated: new types should implement ManagedList.
            +go-lint *failed* | ^
            +go-lint *failed* | pkg/resource/interfaces.go:266:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint *failed* | // Deprecated: new PCUs should implement TypedProviderConfigUsage.
            +go-lint *failed* | ^
            +go-lint *failed* | pkg/resource/predicates.go:28:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint *failed* | // Deprecated: This type will be removed soon. Please use
            +go-lint *failed* | ^
            +go-lint *failed* | pkg/resource/predicates.go:34:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint *failed* | // Deprecated: This function will be removed soon. Please use
            +go-lint *failed* | ^
            +go-lint *failed* | pkg/event/event.go:17:1: package has more than one godoc ("event") (godoclint)
            +go-lint *failed* | 23 issues:
            +go-lint *failed* | * gocritic: 18
            +go-lint *failed* | * godoclint: 4
            +go-lint *failed* | * revive: 1
            +go-lint *failed* | // Package event records Kubernetes events.
            +go-lint *failed* | ^
            +go-lint *failed* | pkg/event/event_test.go:17:1: package has more than one godoc ("event") (godoclint)
            +go-lint *failed* | // Package event records Kubernetes events.
            +go-lint *failed* | ^
            +go-lint *failed* | pkg/reference/namespaced_reference.go:17:1: package has more than one godoc ("reference") (godoclint)
            +go-lint *failed* | // Package reference contains utilities for working with cross-resource
            +go-lint *failed* | ^
            +go-lint *failed* | pkg/reference/reference.go:17:1: package has more than one godoc ("reference") (godoclint)
            +go-lint *failed* | // Package reference contains utilities for working with cross-resource
            +go-lint *failed* | ^
            +go-lint *failed* | pkg/errors/reconcile_test.go:17:9: var-naming: avoid package names that conflict with Go standard library package names (revive)
            +go-lint *failed* | package errors
            +go-lint *failed* |         ^
            +go-lint *failed* | ERROR Earthfile:113:2
            +go-lint *failed* |       The command
            +go-lint *failed* |           RUN golangci-lint run --fix
            +go-lint *failed* |       did not complete successfully. Exit code 1

Help: To debug your build, you can use the --interactive (-i) flag to drop into a shell of the failing RUN step: "earthly -i --strict +go-lint"
File name: Earthfile
Command failed: earthly --strict +go-lint
 Init 🚀
————————————————————————————————————————————————————————————————————————————————

           buildkitd | Found buildkit daemon as docker container (earthly-buildkitd)

 Build 🔧
————————————————————————————————————————————————————————————————————————————————

            +go-lint | --> FROM +base
            +go-lint | --> FROM +go-modules
         +go-modules | --> FROM +base
       golang:1.24.4 | --> Load metadata golang:1.24.4 linux/amd64
         +go-modules | --> FROM golang:1.24.4
         +go-modules | [----------] 100% FROM golang:1.24.4�[K
         +go-modules | *cached* --> WORKDIR /crossplane
         +go-modules | *cached* --> COPY go.mod go.sum ./
         +go-modules | *cached* --> RUN go mod download
            +go-lint | *cached* --> RUN curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin ${GOLANGCI_LINT_VERSION}
            +go-lint | *cached* --> COPY .golangci.yml .
            +go-lint | *cached* --> COPY --dir apis/ pkg/ .
            +go-lint | --> RUN golangci-lint run --fix
            +go-lint | pkg/meta/meta.go:68:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint | // Deprecated: use a more specific reference type, such as TypedReference or
            +go-lint | ^
            +go-lint | pkg/reconciler/managed/policies.go:37:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint | // Deprecated: this is for LegacyManaged types, that had deletion policy.
            +go-lint | ^
            +go-lint | pkg/reconciler/managed/policies.go:132:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint | // Deprecated: this is intended for LegacyManaged resources that had deletionPolicy
            +go-lint | ^
            +go-lint | pkg/reconciler/managed/reconciler_deprecated.go:26:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint | // Deprecated: use ExternalConnector.
            +go-lint | ^
            +go-lint | pkg/reconciler/managed/reconciler_deprecated.go:30:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint | // Deprecated: use TypedExternalConnector.
            +go-lint | ^
            +go-lint | pkg/reconciler/managed/reconciler_deprecated.go:57:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint | // Deprecated: Use NopDisconnector.
            +go-lint | ^
            +go-lint | pkg/reconciler/managed/reconciler_deprecated.go:66:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint | // Deprecated: use NewNopDisconnector.
            +go-lint | ^
            +go-lint | pkg/reconciler/managed/reconciler_deprecated.go:72:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint | // Deprecated: use ExternalDisconnectorFn.
            +go-lint | ^
            +go-lint | pkg/reconciler/managed/reconciler_deprecated.go:76:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint | // Deprecated: use ExternalConnectDisconnectorFns.
            +go-lint | ^
            +go-lint | pkg/reconciler/managed/reconciler_deprecated.go:80:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint | // Deprecated: use NopConnector.
            +go-lint | ^
            +go-lint | pkg/reconciler/managed/reconciler_deprecated.go:84:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint | // Deprecated: use WithExternalConnector.
            +go-lint | ^
            +go-lint | pkg/reconciler/managed/reconciler_deprecated.go:100:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint | // Deprecated: Please use Disconnect() on the ExternalClient for disconnecting from the provider.
            +go-lint | ^
            +go-lint | pkg/reconciler/managed/reconciler_deprecated.go:118:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint | // Deprecated: Please use Disconnect() on the ExternalClient for disconnecting from the provider.
            +go-lint | ^
            +go-lint | pkg/resource/interfaces.go:218:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint | // Deprecated: new namespace-scoped MRs should implement ModernManaged.
            +go-lint | ^
            +go-lint | pkg/resource/interfaces.go:235:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint | // Deprecated: new types should implement ManagedList.
            +go-lint | ^
            +go-lint | pkg/resource/interfaces.go:266:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint | // Deprecated: new PCUs should implement TypedProviderConfigUsage.
            +go-lint | ^
            +go-lint | pkg/resource/predicates.go:28:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint | // Deprecated: This type will be removed soon. Please use
            +go-lint | ^
            +go-lint | pkg/resource/predicates.go:34:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint | // Deprecated: This function will be removed soon. Please use
            +go-lint | ^
            +go-lint | pkg/event/event.go:17:1: package has more than one godoc ("event") (godoclint)
            +go-lint | // Package event records Kubernetes events.
            +go-lint | ^
            +go-lint | pkg/event/event_test.go:17:1: package has more than one godoc ("event") (godoclint)
            +go-lint | // Package event records Kubernetes events.
            +go-lint | ^
            +go-lint | pkg/reference/namespaced_reference.go:17:1: package has more than one godoc ("reference") (godoclint)
            +go-lint | // Package reference contains utilities for working with cross-resource
            +go-lint | ^
            +go-lint | pkg/reference/reference.go:17:1: package has more than one godoc ("reference") (godoclint)
            +go-lint | // Package reference contains utilities for working with cross-resource
            +go-lint | ^
            +go-lint | pkg/errors/reconcile_test.go:17:9: var-naming: avoid package names that conflict with Go standard library package names (revive)
            +go-lint | package errors
            +go-lint |         ^
            +go-lint | 23 issues:
            +go-lint | * gocritic: 18
            +go-lint | * godoclint: 4
            +go-lint | * revive: 1
            +go-lint | ERROR Earthfile:113:2
            +go-lint |       The command
            +go-lint |           RUN golangci-lint run --fix
            +go-lint |       did not complete successfully. Exit code 1

================================== ❌ FAILURE ===================================

            +go-lint *failed* | Repeating the failure error...
            +go-lint *failed* | --> RUN golangci-lint run --fix
            +go-lint *failed* | pkg/meta/meta.go:68:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint *failed* | // Deprecated: use a more specific reference type, such as TypedReference or
            +go-lint *failed* | ^
            +go-lint *failed* | pkg/reconciler/managed/policies.go:37:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint *failed* | // Deprecated: this is for LegacyManaged types, that had deletion policy.
            +go-lint *failed* | ^
            +go-lint *failed* | pkg/reconciler/managed/policies.go:132:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint *failed* | // Deprecated: this is intended for LegacyManaged resources that had deletionPolicy
            +go-lint *failed* | ^
            +go-lint *failed* | pkg/reconciler/managed/reconciler_deprecated.go:26:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint *failed* | // Deprecated: use ExternalConnector.
            +go-lint *failed* | ^
            +go-lint *failed* | pkg/reconciler/managed/reconciler_deprecated.go:30:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint *failed* | // Deprecated: use TypedExternalConnector.
            +go-lint *failed* | ^
            +go-lint *failed* | pkg/reconciler/managed/reconciler_deprecated.go:57:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint *failed* | // Deprecated: Use NopDisconnector.
            +go-lint *failed* | ^
            +go-lint *failed* | pkg/reconciler/managed/reconciler_deprecated.go:66:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint *failed* | // Deprecated: use NewNopDisconnector.
            +go-lint *failed* | ^
            +go-lint *failed* | pkg/reconciler/managed/reconciler_deprecated.go:72:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint *failed* | // Deprecated: use ExternalDisconnectorFn.
            +go-lint *failed* | ^
            +go-lint *failed* | pkg/reconciler/managed/reconciler_deprecated.go:76:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint *failed* | // Deprecated: use ExternalConnectDisconnectorFns.
            +go-lint *failed* | ^
            +go-lint *failed* | pkg/reconciler/managed/reconciler_deprecated.go:80:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint *failed* | // Deprecated: use NopConnector.
            +go-lint *failed* | ^
            +go-lint *failed* | pkg/reconciler/managed/reconciler_deprecated.go:84:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint *failed* | // Deprecated: use WithExternalConnector.
            +go-lint *failed* | ^
            +go-lint *failed* | pkg/reconciler/managed/reconciler_deprecated.go:100:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint *failed* | // Deprecated: Please use Disconnect() on the ExternalClient for disconnecting from the provider.
            +go-lint *failed* | ^
            +go-lint *failed* | pkg/reconciler/managed/reconciler_deprecated.go:118:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint *failed* | // Deprecated: Please use Disconnect() on the ExternalClient for disconnecting from the provider.
            +go-lint *failed* | ^
            +go-lint *failed* | pkg/resource/interfaces.go:218:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint *failed* | // Deprecated: new namespace-scoped MRs should implement ModernManaged.
            +go-lint *failed* | ^
            +go-lint *failed* | pkg/resource/interfaces.go:235:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint *failed* | // Deprecated: new types should implement ManagedList.
            +go-lint *failed* | ^
            +go-lint *failed* | pkg/resource/interfaces.go:266:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint *failed* | // Deprecated: new PCUs should implement TypedProviderConfigUsage.
            +go-lint *failed* | ^
            +go-lint *failed* | pkg/resource/predicates.go:28:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint *failed* | // Deprecated: This type will be removed soon. Please use
            +go-lint *failed* | ^
            +go-lint *failed* | pkg/resource/predicates.go:34:1: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
            +go-lint *failed* | // Deprecated: This function will be removed soon. Please use
            +go-lint *failed* | ^
            +go-lint *failed* | pkg/event/event.go:17:1: package has more than one godoc ("event") (godoclint)
            +go-lint *failed* | // Package event records Kubernetes events.
            +go-lint *failed* | ^
            +go-lint *failed* | pkg/event/event_test.go:17:1: package has more than one godoc ("event") (godoclint)
            +go-lint *failed* | // Package event records Kubernetes events.
            +go-lint *failed* | ^
            +go-lint *failed* | pkg/reference/namespaced_reference.go:17:1: package has more than one godoc ("reference") (godoclint)
            +go-lint *failed* | // Package reference contains utilities for working with cross-resource
            +go-lint *failed* | ^
            +go-lint *failed* | pkg/reference/reference.go:17:1: package has more than one godoc ("reference") (godoclint)
            +go-lint *failed* | // Package reference contains utilities for working with cross-resource
            +go-lint *failed* | ^
            +go-lint *failed* | pkg/errors/reconcile_test.go:17:9: var-naming: avoid package names that conflict with Go standard library package names (revive)
            +go-lint *failed* | package errors
            +go-lint *failed* |         ^
            +go-lint *failed* | 23 issues:
            +go-lint *failed* | * gocritic: 18
            +go-lint *failed* | * godoclint: 4
            +go-lint *failed* | * revive: 1
            +go-lint *failed* | ERROR Earthfile:113:2
            +go-lint *failed* |       The command
            +go-lint *failed* |           RUN golangci-lint run --fix
            +go-lint *failed* |       did not complete successfully. Exit code 1

Help: To debug your build, you can use the --interactive (-i) flag to drop into a shell of the failing RUN step: "earthly -i --strict +go-lint"

@crossplane-renovate crossplane-renovate bot force-pushed the renovate/main-golangci-golangci-lint-2.x branch from f9c6886 to 9f00589 Compare December 4, 2025 08:08
@crossplane-renovate crossplane-renovate bot changed the title chore(deps): update dependency golangci/golangci-lint to v2.6.2 (main) chore(deps): update dependency golangci/golangci-lint to v2.7.0 (main) Dec 4, 2025
@crossplane-renovate crossplane-renovate bot force-pushed the renovate/main-golangci-golangci-lint-2.x branch from 9f00589 to 9198144 Compare December 5, 2025 08:08
@crossplane-renovate crossplane-renovate bot changed the title chore(deps): update dependency golangci/golangci-lint to v2.7.0 (main) chore(deps): update dependency golangci/golangci-lint to v2.7.1 (main) Dec 5, 2025
@crossplane-renovate crossplane-renovate bot force-pushed the renovate/main-golangci-golangci-lint-2.x branch from 9198144 to de2791e Compare December 8, 2025 08:08
@crossplane-renovate crossplane-renovate bot changed the title chore(deps): update dependency golangci/golangci-lint to v2.7.1 (main) chore(deps): update dependency golangci/golangci-lint to v2.7.2 (main) Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bobh66 bobh66 Awaiting requested review from bobh66 bobh66 is a code owner automatically assigned from crossplane/crossplane-maintainers

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

automated

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant