ci: lint and github workflow #1849
Conversation
randy-cro
requested review from
JayT106 and
XinyuCRO
and removed request for
a team
WalkthroughAdds new GitHub issue labeler config, normalizes/reorders PR labeler YAML, tweaks Makefile lint-fix flags, and updates an Ethermint dependency pin in both go.mod and gomod2nix.toml. No runtime code or public API changes. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (21)
🔇 Additional comments (2)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1849 +/- ##
===========================================
+ Coverage 16.87% 35.79% +18.91%
===========================================
Files 72 127 +55
Lines 6163 11812 +5649
===========================================
+ Hits 1040 4228 +3188
- Misses 5000 7161 +2161
- Partials 123 423 +300 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (5)
Makefile (1)
142-142: Optional: keep lint-fix output consistent with lint target.Consider adding
--path-prefix=./(used inlint) so paths in diagnostics are consistent across both targets.- golangci-lint run --fix --issues-exit-code=0 + golangci-lint run --fix --issues-exit-code=0 --path-prefix=./.github/issue_labeler.yml (4)
68-75: Replace chain-maind with cronosd for CLI references.This repo’s binary/CLI is
cronosd, notchain-maind. Update the alias to avoid mislabeling issues.cli: - 'cli' - 'command' - - 'chain-maind' + - 'cronosd' - 'flag' - 'argument' - 'terminal'
98-105: Add CometBFT as a dependency keyword.Cronos (Cosmos SDK v0.47+) typically uses CometBFT instead of Tendermint. Adding this term improves label accuracy for dependency-related issues.
dependencies: - 'dependency' - 'dependencies' - 'go.mod' - 'update' - 'cosmos-sdk' - 'tendermint' + - 'cometbft'
106-113: Nit: add a trailing newline at EOF.Many tools expect a newline at end of file; adding it avoids diffs and editor warnings.
- 'ci' - 'github actions' - 'workflow' +
1-113: Optional: reduce false positives with word boundaries/case-insensitive matching (if supported).Several aliases (e.g., “client”, “chain”, “update”) are generic and may over-label issues. If your chosen action supports regex and flags like ignoreCase, prefer patterns with word boundaries and case-insensitive matching per label.
Example schema (adjust to your action’s format):
- bug:
- pattern: '(?i)\b(bug|error|crash|panic|exception|broken|fail|doesn''t work|not work)\b'
- dependencies:
- pattern: '(?i)\b(go.mod|dependency|dependencies|cosmos-sdk|cometbft|tendermint|update)\b'
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
.github/issue_labeler.yml(1 hunks)Makefile(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.37.1)
.github/issue_labeler.yml
[error] 10-10: syntax error: expected , but found ''
(syntax)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)
- GitHub Check: integration_tests (upgrade)
- GitHub Check: integration_tests (ica)
- GitHub Check: integration_tests (slow)
- GitHub Check: integration_tests (gas)
- GitHub Check: integration_tests (gov)
- GitHub Check: integration_tests (ibc_update_client)
- GitHub Check: integration_tests (ibc_rly_evm)
- GitHub Check: integration_tests (unmarked)
- GitHub Check: integration_tests (ibc_timeout)
- GitHub Check: integration_tests (ibc_rly_gas)
- GitHub Check: integration_tests (ibc)
- GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (2)
Makefile (1)
142-142: Fix removes the stray file creation from lint-fix.Dropping
--output.text.pathresolves the prior misinterpretation where--issues-exit-code=0was treated as a path and a random file was created. This aligns with the PR objective..github/issue_labeler.yml (1)
1-113: Issue labeler workflow and config path verifiedThe
.github/workflows/issue_labeler.ymlworkflow usesgithub/[email protected]and correctly specifies
configuration-path: .github/issue_labeler.yml. No further changes are required.
thomas-nguy
changed the title
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
2 participants
Description
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)
Summary by CodeRabbit