Skip to content

Conversation

@XinyuCRO
Copy link
Contributor

@XinyuCRO XinyuCRO commented Jan 5, 2026

cherry-pick: #1944
ethermint PR: crypto-org-chain/ethermint#814

Summary by CodeRabbit

  • Bug Fixes

    • Improved accuracy of gas estimation.
  • Chores

    • Updated project dependencies to latest versions.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 5, 2026

📝 Walkthrough

Walkthrough

This pull request updates Go module dependencies, specifically bumping the evmos/ethermint replacement to a newer commit version and removing the zeebo/errs dependency entry from manifests. A changelog note documenting a gas estimation fix is also added.

Changes

Cohort / File(s) Summary
Documentation
CHANGELOG.md
Added UNRELEASED entry documenting gas estimation accuracy fix (#1947)
Dependency Updates
go.mod
Updated evmos/ethermint replacement version from v0.22.1-0.20260105042515-e5b2b4df9e8d to v0.22.1-0.20260107054325-46538c97abf2
Nix Manifest Updates
gomod2nix.toml
Updated ethermint mod entry version and hash to match go.mod replacement; removed zeebo/errs mod entry entirely

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • #1845: Updates ethermint dependency references in go.mod replace and gomod2nix entries
  • #1600: Modifies evmos/ethermint dependency version across go.mod and gomod2nix.toml

Suggested reviewers

  • calvinaco
  • yihuang
  • thomas-nguy

Poem

🐰 A bunny hops through dependencies so fine,
Ethermint bumped to a newer design,
Gas calculations now measure true,
Zeebo erased—farewell to you!
With each small hop, the chain grows bright,

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: estimate gas not accurate' directly corresponds to the main objective of the PR (a cherry-pick fixing gas estimation) and is reflected in the CHANGELOG entry, making it clearly relevant to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom Pre-merge Checks in the settings.


📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6d59068 and d2c89f6.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (3)
  • CHANGELOG.md
  • go.mod
  • gomod2nix.toml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)
  • GitHub Check: integration_tests (slow)
  • GitHub Check: integration_tests (gov)
  • GitHub Check: integration_tests (ibc_timeout)
  • GitHub Check: integration_tests (ibc_update_client)
  • GitHub Check: integration_tests (mint)
  • GitHub Check: integration_tests (ica)
  • GitHub Check: integration_tests (ibc_rly_gas)
  • GitHub Check: integration_tests (unmarked)
  • GitHub Check: integration_tests (upgrade)
  • GitHub Check: integration_tests (ibc_rly_evm)
  • GitHub Check: integration_tests (evm)
  • GitHub Check: integration_tests (ibc)
  • GitHub Check: Run golangci-lint
  • GitHub Check: integration_tests (gas)
  • GitHub Check: build (macos-14)
  • GitHub Check: build (macos-latest)
  • GitHub Check: build (ubuntu-latest)
  • GitHub Check: unittest
  • GitHub Check: gomod2nix
  • GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (4)
CHANGELOG.md (1)

17-17: LGTM! Changelog entry is well-formatted.

The changelog entry is properly placed under UNRELEASED Improvements and follows the existing format.

gomod2nix.toml (2)

327-328: Ethermint version update is consistent with go.mod.

The version and hash have been properly updated to match the Ethermint commit bump in go.mod.


1-1: Removal of zeebo/errs is safe and verified.

The dependency has been completely removed from the module management: no references exist in Go source files, and it is absent from both go.mod and go.sum. The build will not be affected.

go.mod (1)

305-305: Verify the Ethermint commit contains the gas estimation fix.

The Ethermint replacement has been updated to commit 46538c97abf2 referenced in the PR description. Manual verification of this external commit's contents is required to confirm it includes the expected gas estimation fixes from ethermint PR #814. Consider adding a note to the CHANGELOG documenting this update and its purpose once verified.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

…x/gas_estimate

# Conflicts:
#	CHANGELOG.md
#	go.mod
#	go.sum
#	gomod2nix.toml
@XinyuCRO XinyuCRO marked this pull request as ready for review January 7, 2026 05:49
@XinyuCRO XinyuCRO requested a review from a team as a code owner January 7, 2026 05:49
@XinyuCRO XinyuCRO requested review from JayT106 and songgaoye and removed request for a team January 7, 2026 05:49
@XinyuCRO XinyuCRO enabled auto-merge January 7, 2026 06:06
@XinyuCRO XinyuCRO added this pull request to the merge queue Jan 7, 2026
Merged via the queue into main with commit f1c7d9e Jan 7, 2026
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants