Skip to content

Problem: missing internal tx when debug trace tx #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from
Draft

Problem: missing internal tx when debug trace tx #575

wants to merge 6 commits into from

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Mar 12, 2025

Closes: #XXX

Description

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@socket-security Socket Security
Copy link

socket-security bot commented Mar 25, 2025 •
edited
Loading

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@thirdweb-dev/[email protected] Transitive: network +44 19.9 MB jnsdls
npm/@uniswap/[email protected] None +5 5.52 MB mtoda
npm/[email protected] None 0 206 kB shunkakinoki

View full report↗︎

github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 1, 2025
View reviewed changes
tests/integration_tests/utils.py
"WETH9": "contracts/mocks/WETH9.sol",
"Forwarder": "@thirdweb-dev/contracts/contracts/infra/forwarder/Forwarder.sol",
"TWRegistry": "@thirdweb-dev/contracts/contracts/infra/TWRegistry.sol",
"TWFactory": "@thirdweb-dev/contracts/contracts/infra/TWFactory.sol",

Check warning

Code scanning / CodeQL

Duplicate key in dict literal Warning test

Dictionary key 'TWFactory' is subsequently
overwritten
Loading
.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mmsqe