Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engine: rework global name representation #1199

Merged
merged 21 commits into from
Jan 30, 2025
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
e5824d5
Revert "New test snapshot."
maximebuyse Jan 30, 2025
b5bceaf
Revert "Rename trait methods in bundles for all backends, but include…
maximebuyse Jan 30, 2025
5530d5a
Revert "Move trait methods in cyclic dependencies bundling."
maximebuyse Jan 30, 2025
7fe83d6
feat(ocaml): derive more for types
W95Psp Dec 10, 2024
9661926
Complete redesign of concrete identifiers
W95Psp Dec 18, 2024
79ab4b8
refactor: make inline lib require no new concrete identifiers
W95Psp Jan 27, 2025
3ffefff
Remove dummy method in opaque trait impls.
maximebuyse Jan 27, 2025
c6d9023
Keep renamings for sub-idents that are NOT anonymous.
maximebuyse Jan 27, 2025
fb1d591
Fix clash of names between enums and structs in bundles.
maximebuyse Jan 28, 2025
7ed7906
Avoid importing constructors from bundles when they don't exist.
maximebuyse Jan 29, 2025
b14f800
Avoid disambiguating fields of the same struct.
maximebuyse Jan 29, 2025
ee47a83
Allow type aliases in concrete idents.
maximebuyse Jan 29, 2025
2bab5db
We shouldn't produce aliases for Quote items in bundles.
maximebuyse Jan 29, 2025
00d829a
Make sure refinement types end up in their original module.
maximebuyse Jan 29, 2025
c7f4187
Correct origin for quote items.
maximebuyse Jan 29, 2025
2a3e840
Lower-case prefix for anonymous constants.
maximebuyse Jan 29, 2025
4e8dcb0
Test snapshots for new naming.
maximebuyse Jan 29, 2025
da3eeaa
Adapt core lib to new naming.
maximebuyse Jan 29, 2025
4335f70
Better documentation for new naming.
maximebuyse Jan 30, 2025
0eb63e5
misc(engine): drop stale comment
W95Psp Jan 30, 2025
051c4eb
Fix proverif backend with new naming.
maximebuyse Jan 30, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
We shouldn't produce aliases for Quote items in bundles.
maximebuyse committed Jan 30, 2025
commit 2bab5db97e4bb2d1d1e85dfeb3e426366ee69246
1 change: 1 addition & 0 deletions engine/lib/dependencies.ml
Original file line number Diff line number Diff line change
@@ -527,6 +527,7 @@ module Make (F : Features.T) = struct
when List.for_all variants ~f:(fun variant -> variant.is_record)
&& Concrete_ident.is_constructor from_id ->
None
| Quote _ -> None
| _ -> Some { attrs; span = origin_item.span; ident = from_id; v })
in
let rename =