Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mkdocs): use codemirror instead of ace, re-setup on page reload #1277

Merged
merged 1 commit into from
Jan 30, 2025
Merged

fix(mkdocs): use codemirror instead of ace, re-setup on page reload #1277

merged 1 commit into from
Jan 30, 2025

Conversation

W95Psp
Copy link
Collaborator

@W95Psp W95Psp commented Jan 30, 2025 •
edited
Loading

This PR:

  • re-installs editors on JS naviation
  • uses codemirror instead of ace (ace editors were messed up after re-installs)
  • formats properly the results

Fixes #1226

@W95Psp W95Psp requested a review from a team as a code owner January 30, 2025 09:49
@W95Psp W95Psp force-pushed the fix-docs-playground branch from ea42848 to e195d5e Compare January 30, 2025 09:51
franziskuskiefer
franziskuskiefer approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! looks like the code is working again 🥳

@franziskuskiefer franziskuskiefer added this pull request to the merge queue Jan 30, 2025
Merged via the queue into main with commit dca12c9 Jan 30, 2025
15 checks passed
@franziskuskiefer franziskuskiefer deleted the fix-docs-playground branch January 30, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franziskuskiefer franziskuskiefer franziskuskiefer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: playground integration: polish and fix bugs
2 participants
@W95Psp @franziskuskiefer