fix(engine) Make sure origins are renamed in bundles. #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximebuyse
force-pushed
the
fix-raw-fstar-bundle
branch
from
337e5a7 to
8f355b8
Compare
|
@W95Psp I changed my fix to actually fix the visitor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1177
The crash was due to the
item_identofitem_quote_origin(insideQuoteitems) not being renamed when a bundle is created. This is apparently a weird bug of the visitor (I would expectvisit_concrete_identto be called on this name without having to overridevisit_item_quote_origin).