Engine: generalize names.rs into a crate
#428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
W95Psp
force-pushed
the
generalize-names-rs
branch
2 times, most recently
from
99cfc34 to
8dd350b
Compare
|
CI is finally green, after hours of debugging 🥳 |
jschneider-bensch
approved these changes
Jan 15, 2024
W95Psp
force-pushed
the
generalize-names-rs
branch
from
e1713bd to
44381fe
Compare
Co-authored-by: jschneider-bensch <[email protected]>
W95Psp
force-pushed
the
generalize-names-rs
branch
from
44381fe to
c65f9b8
Compare
W95Psp
added a commit
that referenced
this pull request
Jan 16, 2024
PR #428 added a heavy dependency to `hax-engine`, dependency that is expected to be built locally when developing on hax.
W95Psp
added a commit
that referenced
this pull request
Apr 24, 2024
This commit fixes the test harness: since #428, the test harness silently assumes hax is in PATH while building the crate `hax-engine-names-extract`. This crate `hax-engine-names-extract` is used at build time by the engine to list and import the Rust names we rely on. `hax-engine-names-extract` itself requires the Rust part of hax at build time. This PR fixes the test harness so that: 1. it asks cargo to build `cargo-hax` and the driver 2. it looks for the path of `cargo-hax` & driver just built (somewhere local in `target/bin/something/someting`), injects thoses paths as env vars in a `cargo build --bin hax-engine-names-extract`; 3. it compiles the engine with the three paths mentioned above (which are required by the engine at compile time); 4. it runs full hax (frontend + engine) on the actual tests; 5. compare with snapshots.
W95Psp
added a commit
that referenced
this pull request
Apr 25, 2024
This commit fixes the test harness: since #428, the test harness silently assumes hax is in PATH while building the crate `hax-engine-names-extract`. This crate `hax-engine-names-extract` is used at build time by the engine to list and import the Rust names we rely on. `hax-engine-names-extract` itself requires the Rust part of hax at build time. This PR fixes the test harness so that: 1. it asks cargo to build `cargo-hax` and the driver 2. it looks for the path of `cargo-hax` & driver just built (somewhere local in `target/bin/something/someting`), injects thoses paths as env vars in a `cargo build --bin hax-engine-names-extract`; 3. it compiles the engine with the three paths mentioned above (which are required by the engine at compile time); 4. it runs full hax (frontend + engine) on the actual tests; 5. compare with snapshots.
W95Psp
added a commit
that referenced
this pull request
Apr 25, 2024
This commit fixes the test harness: since #428, the test harness silently assumes hax is in PATH while building the crate `hax-engine-names-extract`. This crate `hax-engine-names-extract` is used at build time by the engine to list and import the Rust names we rely on. `hax-engine-names-extract` itself requires the Rust part of hax at build time. This PR fixes the test harness so that: 1. it asks cargo to build `cargo-hax` and the driver 2. it looks for the path of `cargo-hax` & driver just built (somewhere local in `target/bin/something/someting`), injects thoses paths as env vars in a `cargo build --bin hax-engine-names-extract`; 3. it compiles the engine with the three paths mentioned above (which are required by the engine at compile time); 4. it runs full hax (frontend + engine) on the actual tests; 5. compare with snapshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gets rid of
names.rsandgenerate.shin favor of the crateengine/names.I replaced
generate.sh(which was a bit of an acrobatic bash script) with the Rust binaryengine/names/extractwhich ensures type safety.This PR fixes the issues #410 and #363.
I added a bit of documentation on how the purpose and on how to use
engine/namesas well.