Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix core ops range tc #440

Merged
merged 3 commits into from
Jan 19, 2024
Merged

Fix core ops range tc #440

merged 3 commits into from
Jan 19, 2024

Conversation

W95Psp
Copy link
Collaborator

@W95Psp W95Psp commented Jan 18, 2024

This PR:

  • fixes the F* typeclass inference in Core.Ops.Range (cc @karthikbhargavan);
  • tweak the makefiles a bit.

@W95Psp W95Psp mentioned this pull request Jan 18, 2024
Merged
@W95Psp W95Psp force-pushed the fix-core-ops-range-tc branch from 16066ac to 2dff22b Compare January 18, 2024 17:07
@karthikbhargavan karthikbhargavan mentioned this pull request Jan 19, 2024
Merged
karthikbhargavan
karthikbhargavan approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@karthikbhargavan karthikbhargavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are needed for Kyber. I added a couple more changes to fix universes, hoping that they help avoid regressions.

@franziskuskiefer franziskuskiefer added this pull request to the merge queue Jan 19, 2024
Merged via the queue into main with commit 164e903 Jan 19, 2024
9 checks passed
@franziskuskiefer franziskuskiefer deleted the fix-core-ops-range-tc branch January 19, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthikbhargavan karthikbhargavan karthikbhargavan approved these changes

@franziskuskiefer franziskuskiefer Awaiting requested review from franziskuskiefer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@W95Psp @karthikbhargavan @franziskuskiefer