Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document valid CFG for Hax #986

Closed
wants to merge 17 commits into from
Closed

Document valid CFG for Hax #986

wants to merge 17 commits into from

Conversation

cmester0
Copy link
Collaborator

Generate the accepted Hax syntax using a shallow printer.

@cmester0 cmester0 marked this pull request as draft October 10, 2024 14:59
@cmester0
Copy link
Collaborator Author

Alternative to #975

@cmester0 cmester0 changed the title Hax auto syntax Document valid CFG for Hax Oct 10, 2024
@cmester0 cmester0 closed this Oct 12, 2024
@cmester0 cmester0 reopened this Oct 12, 2024
@cmester0
Copy link
Collaborator Author

I am currently generating the AST as EBNF, thus we can use tools like https://rr.red-dove.com/ui to render a diagram of the AST.

@franziskuskiefer
Copy link
Member

@cmester0 what does it take to get this in a reviewable state? The plan was to get this done this week.

@W95Psp W95Psp force-pushed the rust-generic-printer branch 2 times, most recently from 9ad1058 to 632484b Compare October 21, 2024 12:56
Base automatically changed from rust-generic-printer to main October 22, 2024 12:51
@cmester0 cmester0 force-pushed the hax-auto-syntax branch 2 times, most recently from bb4fd9a to 989e8e6 Compare October 24, 2024 14:48
@cmester0 cmester0 changed the base branch from main to ast-generator October 24, 2024 14:50
@cmester0 cmester0 marked this pull request as ready for review October 24, 2024 15:46
@cmester0
Copy link
Collaborator Author

This should be mostly ready for review. Only missing description for some cases.

@cmester0
Copy link
Collaborator Author

cmester0 commented Oct 29, 2024 •
edited
Loading

Print EBNF formula as a command (not sure the setup is correct). Currently a full generic printer is implemented for this, however, we might be able to instrument e.g. a rust generic printer as a layered printer being able to print the EBNF formula. Currently uses #1038 to generate elements to be printed.

@cmester0 cmester0 requested a review from W95Psp October 29, 2024 11:02
@cmester0 cmester0 mentioned this pull request Oct 29, 2024
Merged
W95Psp
W95Psp requested changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@W95Psp W95Psp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should use the Rust printer, but instrumented towards EBNF printing

@github-actions GitHub Actions
Copy link

This PR has been marked as stale due to a lack of activity for 60 days. If you believe this pull request is still relevant, please provide an update or comment to keep it open. Otherwise, it will be closed in 7 days.

@github-actions github-actions bot added the stale label Jan 23, 2025
@franziskuskiefer
Copy link
Member

Closing this, please re-open @cmester0 if it's something you want to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@W95Psp W95Psp W95Psp requested changes

Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmester0 @franziskuskiefer @W95Psp