-
Notifications
You must be signed in to change notification settings - Fork 0
Simd Models #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Simd Models #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed and have questions/remarks about documentation (which is also what I mostly looked at). Otherwise things look fine, thanks for the cleanup!
Co-authored-by: maximebuyse <[email protected]>
Co-authored-by: maximebuyse <[email protected]>
Co-authored-by: maximebuyse <[email protected]>
Co-authored-by: maximebuyse <[email protected]>
Co-authored-by: maximebuyse <[email protected]>
Co-authored-by: maximebuyse <[email protected]>
Co-authored-by: maximebuyse <[email protected]>
Co-authored-by: maximebuyse <[email protected]>
Co-authored-by: maximebuyse <[email protected]>
Co-authored-by: maximebuyse <[email protected]>
Co-authored-by: maximebuyse <[email protected]>
Co-authored-by: maximebuyse <[email protected]>
Co-authored-by: maximebuyse <[email protected]>
Co-authored-by: maximebuyse <[email protected]>
Co-authored-by: maximebuyse <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added 2 suggested changes to fix warnings when running cargo doc
. Apart from that it looks good to me with the latest changes!
Co-authored-by: maximebuyse <[email protected]>
Co-authored-by: maximebuyse <[email protected]>
@@ -0,0 +1,173 @@ | |||
# testable-simd-models |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The README looks good to me, it is clear and concise. The example takes a lot of space though, mostly because of the enumeration of masks. Maybe we could shorten it, for example cutting the middle values for the masks and adding a ...
Solution to challenge 15, via cryspen-ext/core-models:simd-debug
Resolves model-checking#173
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.
This PR provides testable models for
core::arch
intrinsics, including abstractions to streamline the process of implementing these intrinsics and their tests. Currently there are 256 x86 intrinsics modelled, and 181 aarch64 intrinsics modelled.This PR also updates the nightly version from 2024-11-03 to 2025-06-30. This is because in the 2024-11-03 version, there are bugs in the implementation of two intrinsics, specifically
_mm256_alignr_epi8
and_mm256_bsrli_epi128
. The latter of these bugs was fixed with the 2025-06-30 version, while the prior one was done sometime earlier, but after 2024-11-03.