Skip to content

Simd Models #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 37 commits into
base: main
Choose a base branch
from
Open

Simd Models #1

wants to merge 37 commits into from

Conversation

satiscugcat
Copy link
Collaborator

@satiscugcat satiscugcat commented Jun 30, 2025

Solution to challenge 15, via cryspen-ext/core-models:simd-debug

Resolves model-checking#173

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

This PR provides testable models for core::arch intrinsics, including abstractions to streamline the process of implementing these intrinsics and their tests. Currently there are 256 x86 intrinsics modelled, and 181 aarch64 intrinsics modelled.

This PR also updates the nightly version from 2024-11-03 to 2025-06-30. This is because in the 2024-11-03 version, there are bugs in the implementation of two intrinsics, specifically _mm256_alignr_epi8 and _mm256_bsrli_epi128. The latter of these bugs was fixed with the 2025-06-30 version, while the prior one was done sometime earlier, but after 2024-11-03.

Copy link
Collaborator

@maximebuyse maximebuyse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed and have questions/remarks about documentation (which is also what I mostly looked at). Otherwise things look fine, thanks for the cleanup!

satiscugcat and others added 20 commits July 10, 2025 17:58
Copy link
Collaborator

@maximebuyse maximebuyse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added 2 suggested changes to fix warnings when running cargo doc. Apart from that it looks good to me with the latest changes!

@@ -0,0 +1,173 @@
# testable-simd-models
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README looks good to me, it is clear and concise. The example takes a lot of space though, mostly because of the enumeration of masks. Maybe we could shorten it, for example cutting the middle values for the masks and adding a ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Challenge 15: High-Assurance SIMD Intrinsics for Rust
2 participants