Refactor Formatter#visit(Call)
#16139
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a series of patches to refactor the formatter logic for formatting a
Callnode. This is quite a complex matter with lots of alternative strategies.The primary change is extracting all these different cases into separate methods, in order to clarify scopes and control flow.
Alongside are a couple smaller improvements for code simplification.
I'm not sure if this should be merged as a single change because we lose the commit history. We might want to merge the
Extractcommits together as one major edit which only moves code around. And a few smaller PRs for the other changes.