Skip to content

Replaced python2 with python3 #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ummthespruce
Copy link

Prerequisite Checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Updated relevant documentation (if needed).

Description of changes

Signed-off-by: ummthespruce <[email protected]>
Signed-off-by: ummthespruce <[email protected]>
Signed-off-by: ummthespruce <[email protected]>
Copy link

@teodutu teodutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason we're using Python 2 is that students will find it easier to write python2 -c 'print ...' rather than python3 -c 'import sys; sys.stdout.buffer.write(.... We're targeting 1st year students, they'll find it difficult to understand why print(...) doesn't work or how sys.stdout.buffer.write() differs.

@StefanJum
Copy link

The reason we're using Python 2 is that students will find it easier to write python2 -c 'print ...' rather than python3 -c 'import sys; sys.stdout.buffer.write(.... We're targeting 1st year students, they'll find it difficult to understand why print(...) doesn't work or how sys.stdout.buffer.write() differs.

Python2 is deprecated (has been for a long time), and if you want it on ubuntu 24 you need to build it yourself.
The student vms will be ubuntu 24. I think we can safely go for python3 only, it's one line of code that can pe copy pasted every time, and it is copy pasted every time for python2 too.

Copy link

@teodutu teodutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok now it makes more sense @StefanJum. Python3 it is.

@teodutu
Copy link

teodutu commented Feb 24, 2025

@ummthespruce before we merge this, please squash your commits and then reword the commit message according to the guidelines: https://github.com/cs-pub-ro/hardware-software-interface/blob/main/CONTRIBUTING.md#commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants