-
Notifications
You must be signed in to change notification settings - Fork 48
labs/lab-10: Add checker infrastructure #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
f9a11bf
to
d2394e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only made an initial review with some first requirements. Change the infrastructure to bash scripts to make it easier to test the actual payloads noninteractively and then I'll give this another go.
labs/lab-10/tasks/overflow-for-binary/tests/test_overflow_for_binary.c
Outdated
Show resolved
Hide resolved
labs/lab-10/tasks/overflow-for-binary/tests/test_overflow_for_binary.c
Outdated
Show resolved
Hide resolved
73f9de5
to
c9a8fd7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The checkers are mostly working correctly, except for stack-buffer
. For the others, I left some comments in one of the tasks that should be applied to all of them. In addition, make all binaries in support/
executable.
1d3b6a8
to
d143784
Compare
- Added for each task a directory named tests - Added for each task a specified checker in directory tests - Added for each task an exploit.py file with some TODOs - Updated the hardcoded part and got rid of the fixed payload - Added instructions in the README about completing exploit.py TODOs and running make check in tests for showing the results - Added some detailed explanations in README files - Deleted the exploit.py files from stack_buffer directory - Added more detailed tests for stack_buffer exercise Fixes cs-pub-ro#43 Signed-off-by: Alexandru Braslasu <[email protected]>
d143784
to
e621c3a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nearly there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make all run_all_tests.sh
scripts executable.
|
||
def run_executable(): | ||
argument = 32 * "A" + "\x50\x52\x30\x4e" | ||
subprocess.run(["./overflow_in_binary", argument]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make overflow_in_binary
executable in the support/
folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you remove this file? Leave it in the repo because students aren't supposed to generate it.
Fixes #43
Prerequisite Checklist
Description of changes