Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added code to create more complex variables #24

Open
wants to merge 1 commit into
base: csv-output
Choose a base branch
from

Conversation

dcher95
Copy link

@dcher95 dcher95 commented Oct 28, 2020

Created var_dict instead of list initially. Then used dataframes and list comprehension to recreate trainAgentsDict

@dcher95 dcher95 requested a review from yahelnachum October 28, 2020 18:14
Copy link
Collaborator

@yahelnachum yahelnachum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Skimmed the code and got a general sense of what it's doing. Just want to double check if any important changes were made to lyft-rnn-lstm.ipynb.

{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dcher95 are there any actual changes to this notebook. If so could you push the script version for easy review.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes because I assumed the other notebook was the production script due to errors. Is this script for production?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I think the other one is the prod script now 👍 . Thanks for confirming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants