Skip to content

Traceback #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Traceback #25

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dcf5543
add tracebacks on views exceptions
enricobacis May 31, 2016
d9a1718
redirect to login directly if not authenticated
enricobacis Jun 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions swiftbrowser/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import time
import urlparse
import hmac
import traceback
from hashlib import sha1

from swiftclient import client
Expand Down Expand Up @@ -41,6 +42,7 @@ def login(request):
return redirect(containerview)

except client.ClientException:
traceback.print_exc()
messages.add_message(request, messages.ERROR, _("Login failed."))

return render_to_response('login.html', {'form': form, },
Expand All @@ -53,9 +55,13 @@ def containerview(request):
storage_url = request.session.get('storage_url', '')
auth_token = request.session.get('auth_token', '')

if not storage_url or not auth_token:
return redirect(login)

try:
account_stat, containers = client.get_account(storage_url, auth_token)
except client.ClientException as exc:
traceback.print_exc()
if exc.http_status == 403:
account_stat = {}
containers = []
Expand Down Expand Up @@ -91,6 +97,7 @@ def create_container(request):
messages.add_message(request, messages.INFO,
_("Container created."))
except client.ClientException:
traceback.print_exc()
messages.add_message(request, messages.ERROR, _("Access denied."))

return redirect(containerview)
Expand All @@ -113,6 +120,7 @@ def delete_container(request, container):
client.delete_container(storage_url, auth_token, container)
messages.add_message(request, messages.INFO, _("Container deleted."))
except client.ClientException:
traceback.print_exc()
messages.add_message(request, messages.ERROR, _("Access denied."))

return redirect(containerview)
Expand All @@ -130,6 +138,7 @@ def objectview(request, container, prefix=None):
prefix=prefix)

except client.ClientException:
traceback.print_exc()
messages.add_message(request, messages.ERROR, _("Access denied."))
return redirect(containerview)

Expand Down Expand Up @@ -227,6 +236,7 @@ def delete_object(request, container, objectname):
client.delete_object(storage_url, auth_token, container, objectname)
messages.add_message(request, messages.INFO, _("Object deleted."))
except client.ClientException:
traceback.print_exc()
messages.add_message(request, messages.ERROR, _("Access denied."))
if objectname[-1] == '/': # deleting a pseudofolder, move one level up
objectname = objectname[:-1]
Expand All @@ -245,6 +255,7 @@ def toggle_public(request, container):
try:
meta = client.head_container(storage_url, auth_token, container)
except client.ClientException:
traceback.print_exc()
messages.add_message(request, messages.ERROR, _("Access denied."))
return redirect(containerview)

Expand All @@ -260,6 +271,7 @@ def toggle_public(request, container):
try:
client.post_container(storage_url, auth_token, container, headers)
except client.ClientException:
traceback.print_exc()
messages.add_message(request, messages.ERROR, _("Access denied."))

return redirect(objectview, container=container)
Expand All @@ -274,6 +286,7 @@ def public_objectview(request, account, container, prefix=None):
storage_url, auth_token, container, delimiter='/', prefix=prefix)

except client.ClientException:
traceback.print_exc()
messages.add_message(request, messages.ERROR, _("Access denied."))
return redirect(containerview)

Expand Down Expand Up @@ -348,6 +361,7 @@ def create_pseudofolder(request, container, prefix=None):
messages.add_message(request, messages.INFO,
_("Pseudofolder created."))
except client.ClientException:
traceback.print_exc()
messages.add_message(request, messages.ERROR, _("Access denied."))

if prefix:
Expand Down Expand Up @@ -407,6 +421,7 @@ def edit_acl(request, container):
message = "ACLs updated."
messages.add_message(request, messages.INFO, message)
except client.ClientException:
traceback.print_exc()
message = "ACL update failed"
messages.add_message(request, messages.ERROR, message)

Expand Down Expand Up @@ -437,6 +452,7 @@ def edit_acl(request, container):
message = "ACL removed."
messages.add_message(request, messages.INFO, message)
except client.ClientException:
traceback.print_exc()
message = "ACL update failed."
messages.add_message(request, messages.ERROR, message)

Expand Down