Skip to content

feat: esm with type module #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 28, 2023
Merged

feat: esm with type module #25

merged 4 commits into from
Feb 28, 2023

Conversation

cseas
Copy link
Owner

@cseas cseas commented Feb 28, 2023

Description

Changes the project to use ESM files with type module.

The ignoreBuildErrors config is needed to ignore type errors caused by Next.js bugs:

Checklist

  • My changes generate no new warnings
  • I've done a self-review of this pull request

@changeset-bot
Copy link

changeset-bot bot commented Feb 28, 2023

🦋 Changeset detected

Latest commit: 9669e49

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
blog Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
blog ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 28, 2023 at 10:28PM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2023

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 95.61 KB (🟡 +9.84 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Four Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/learn 275.52 KB (🟢 -7.63 KB) 371.13 KB
/learn/[id] 275.52 KB (🟢 -7.63 KB) 371.13 KB
/posts 275.52 KB (🟢 -7.63 KB) 371.13 KB
/posts/[id] 275.52 KB (🟢 -7.63 KB) 371.13 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant