fix: stop autocmds from duplicating on each SSR open #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SSR creates instances when you Ui:Open but the autocmds are not treated like an instance they are sharing the same autocmds, these autocmds how ever are being duplicated on each run of Ui:Open causing bad side effects like data invalidation changes in this commit creates a unique augroup and allows only one autocmd per instance then removes them once the instance is closed.
A-Lamia
force-pushed
the
fix-autocmd-duplication
branch
from
d8c7b4e to
d02f7dc
Compare
Owner
|
autocmd group is also added in #31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSR creates instances when Ui:Open is executed but the autocmds are not treated like an instance they are sharing the same autocmds, these autocmds however are being duplicated on each run of Ui:Open causing bad side effects like data invalidation.
On instance creation a unique augroup is created and assigned and only one set of autocmds are allowed to exist each instance, when that instance of SSR is closed the assigned autocmds and augroup is removed for that instance only.