Add handle_protocol_mut #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is immediately useful for checking partition types/GUIDs for block and disk I/O, but is also useful elsewhere.
Some function calls require image handles in place of the LoadedImageProtocol struct, so track it for library consumers that may want to use it.
Some applications want to set or read load_options (and the corresponding size field).
Implement handle_protocol_mut, and stop using mem::transmute in handle_protocol.
|
Would it make sense to implement |
|
I don't believe so; typically Rust APIs that expose both |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some applications may need to acquire a mutable protocol from
handle_protocol.Note: includes commits also in #18