parser-cov: align assignment of key events with Coverity #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They cannot be propagated through the plain-text format and could cause artificial differences when compared with JSON. Related: https://issues.redhat.com/browse/OSH-552
... to improve code readability Related: https://issues.redhat.com/browse/OSH-552
Instead of `use_same_locks_for_read_and_modify` we need to pick `thread1_overwrites_value_in_field` in the example used as a test. Related: https://issues.redhat.com/browse/OSH-552
kdudka
added a commit
to kdudka/csdiff
that referenced
this pull request
Feb 20, 2024
... in forward direction, which seems to be more compatible with Coverity's native assignment of key events. Resolves: https://issues.redhat.com/browse/OSH-552 Closes: csutils#165
kdudka
force-pushed
the
cov-parser-overhaul
branch
from
821265e to
edcb5bc
Compare
kdudka
added a commit
to kdudka/csdiff
that referenced
this pull request
Feb 21, 2024
... only for RESOURCE_LEAK, UNINIT, and UNINIT_CTOR. Coverity is inconsistent in this and the plain-text parser in csdiff needs to follow it. Resolves: https://issues.redhat.com/browse/OSH-552 Closes: csutils#165
kdudka
force-pushed
the
cov-parser-overhaul
branch
from
edcb5bc to
9a3a622
Compare
kdudka
added a commit
to kdudka/csdiff
that referenced
this pull request
Feb 21, 2024
... only for RESOURCE_LEAK, UNINIT, and UNINIT_CTOR. Coverity is inconsistent in this and the plain-text parser in csdiff needs to follow it. Resolves: https://issues.redhat.com/browse/OSH-552 Closes: csutils#165
kdudka
force-pushed
the
cov-parser-overhaul
branch
from
9a3a622 to
3606446
Compare
kdudka
added a commit
to kdudka/csdiff
that referenced
this pull request
Feb 21, 2024
... to better emulate how Coverity itself assign key events. Resolves: https://issues.redhat.com/browse/OSH-552 Closes: csutils#165
kdudka
force-pushed
the
cov-parser-overhaul
branch
from
3606446 to
a8b3dec
Compare
kdudka
added a commit
to kdudka/csdiff
that referenced
this pull request
Feb 21, 2024
kdudka
force-pushed
the
cov-parser-overhaul
branch
from
a8b3dec to
c0d34b8
Compare
... to match the assignment used by Coverity's JSON v7 format Related: https://issues.redhat.com/browse/OSH-552
... in forward direction, which seems to be more compatible with Coverity's native assignment of key events. Related: https://issues.redhat.com/browse/OSH-552
... in forward direction, which seems to be more compatible with Coverity's native assignment of key events. Related: https://issues.redhat.com/browse/OSH-552
... to match the assignment used by Coverity's JSON v7 format Related: https://issues.redhat.com/browse/OSH-552
... only for RESOURCE_LEAK, UNINIT, and UNINIT_CTOR. Coverity is inconsistent in this and the plain-text parser in csdiff needs to follow it. Related: https://issues.redhat.com/browse/OSH-552
... to better emulate how Coverity itself assign key events. Related: https://issues.redhat.com/browse/OSH-552
kdudka
added a commit
to kdudka/csdiff
that referenced
this pull request
Feb 21, 2024
kdudka
force-pushed
the
cov-parser-overhaul
branch
from
c0d34b8 to
a3cdbc4
Compare
kdudka
added a commit
to kdudka/csdiff
that referenced
this pull request
Feb 22, 2024
The 2nd event is a key event in the following finding from Coverity: ``` Error: SOCKET_ACCEPT_ALL_ORIGINS (CWE-942): grafana-9.2.10/vendor/github.com/gorilla/websocket/server.go:302: go_socketio_all_origins: The function "function anonymous%1" always returns "true". grafana-9.2.10/vendor/github.com/gorilla/websocket/server.go:302: go_socketio_all_origins: The function "Upgrader.CheckOrigin()" always returns "true" to accept requests from all origins. grafana-9.2.10/vendor/github.com/gorilla/websocket/server.go:302: go_socketio_all_origins: Modify the "Upgrader.CheckOrigin()" function to only return "true" for trusted origins, or remove the function completely since the default "Upgrader" will only create "WebSocket" connections with clients from the same origin. ``` Related: https://issues.redhat.com/browse/OSH-552 Closes: csutils#165
kdudka
force-pushed
the
cov-parser-overhaul
branch
from
a3cdbc4 to
ef63a3d
Compare
The 2nd event is a key event in the following finding from Coverity: ``` Error: SOCKET_ACCEPT_ALL_ORIGINS (CWE-942): grafana-9.2.10/vendor/github.com/gorilla/websocket/server.go:302: go_socketio_all_origins: The function "function anonymous%1" always returns "true". grafana-9.2.10/vendor/github.com/gorilla/websocket/server.go:302: go_socketio_all_origins: The function "Upgrader.CheckOrigin()" always returns "true" to accept requests from all origins. grafana-9.2.10/vendor/github.com/gorilla/websocket/server.go:302: go_socketio_all_origins: Modify the "Upgrader.CheckOrigin()" function to only return "true" for trusted origins, or remove the function completely since the default "Upgrader" will only create "WebSocket" connections with clients from the same origin. ``` Related: https://issues.redhat.com/browse/OSH-552 Closes: csutils#165
kdudka
force-pushed
the
cov-parser-overhaul
branch
from
ef63a3d to
4a17373
Compare
|
/packit build |
hanchuntao
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://issues.redhat.com/browse/OSH-552