csgrep --set-scan-prop: override the specified scan property #85
+286
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much for working on this. I'm going to test it in |
kdudka
force-pushed
the
set-scan-prop
branch
from
e7f0db6 to
47c9540
Compare
lzaoral
requested changes
Sep 26, 2022
kdudka
added a commit
to kdudka/csdiff
that referenced
this pull request
Sep 26, 2022
kdudka
force-pushed
the
set-scan-prop
branch
from
fab7f9d to
9661935
Compare
|
@lzaoral Thanks for review! I have updated the pull request. |
kdudka
added a commit
to kdudka/csdiff
that referenced
this pull request
Sep 26, 2022
kdudka
force-pushed
the
set-scan-prop
branch
from
9661935 to
c4cb345
Compare
1 task
jamacku
approved these changes
Sep 26, 2022
If git-describe fails, an empty string is assigned to CS_VERSION, which breaks the regression tests that expect csdiff version to be available. Unfortunately, `git describe --tags` is not compatible with checkout@v3 GitHub Action.
... and fallback to csdiff as the tool only if the scan properties are not available.
... in GenericAbstractFilter to avoid duplicated code in its derivates. No changes in behavior intended by this change.
... to chain any decorators that take a single argument. Rename the other helper to chainDecoratorIntArg for consistency. No changes in behavior intended by this change.
kdudka
force-pushed
the
set-scan-prop
branch
from
c4cb345 to
ceb9b62
Compare
|
@jamacku Perfect, thank you for testing it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #82