Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Fix parallel run #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jkuchar
Copy link

@jkuchar jkuchar commented Apr 3, 2023

Description

Fix, so this tool can be used when run UI tests in parallel.

Detailed Design

There need to provide parameter for binary OR configuration if in SwiftClient OR detecting evenironment and passing the information over the HTTP parameter.

Documentation

Once there will be decision, how the parameter will be passed, documentation will need to updated

Testing

N/A, just draft for now

Performance

No impact.

Source Impact

The current draft break support for sequential run. If passed as parameter, there will be no BC break.

Checklist

  • I've read the Contribution Guidelines
  • I've followed the coding style of the rest of the project.
  • I've added tests covering all new code paths my change adds to the project (to the extent possible).
  • I've added benchmarks covering new functionality (if appropriate).
  • I've verified that my change does not break any existing tests or introduce unexpected benchmark regressions.
  • I've updated the documentation (if appropriate).

Result

image

@jkuchar jkuchar requested a review from ctreffs as a code owner April 3, 2023 15:47
@jkuchar jkuchar mentioned this pull request Apr 3, 2023
bin/SimctlCLI Outdated
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have rebuild binary, so I can use my fork and use in the CI.

@@ -19,7 +19,7 @@ extension ShellOutCommand {
}

private static func simctl(_ cmd: String) -> String {
"xcrun simctl \(cmd)"
"xcrun simctl --set testing \(cmd)"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept of sets is described on stackoverflow: https://stackoverflow.com/a/58293549/631369

  • default set is path ~/Library/Developer/CoreSimulator/Devices source
  • "testing" is ~/Library/Developer/XCTestDevices source, which is used by parallel UI test runner
  • previews set, that is used by Xcode for rendering previews. source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant