Skip to content

[lts86] Switch to unversioned configs #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 18, 2025

Conversation

bmastbergen
Copy link
Collaborator

  • build-check: Use unversioned config
  • configs: Remove kernel-4.18.0-*.config

LE-2786
LE-2787

Note: ./scripts/dummy-tools doesn't exist in this branch, so I didn't switch to that for olddefconfig

@PlaidCat
Copy link
Collaborator

PlaidCat commented Apr 17, 2025

Could you change this:

build-check: Use unversioned config 

to

github actions: build-check use unversioned config 

also this is silly but the header check we have is like the following, could you put both commits in to that format.
https://github.com/ctrliq/kernel-src-tree/wiki#commit-message-header
I know we don't have much for our own commits here but we should remain consistent

<commit summary>

<CIQ HEADER, jira number here>

<Commit Body>

Otherwise looks good

@bmastbergen
Copy link
Collaborator Author

Could you change this:

build-check: Use unversioned config 

to

github actions: build-check use unversioned config 

also this is silly but the header check we have is like the following, could you put both commits in to that format. https://github.com/ctrliq/kernel-src-tree/wiki#commit-message-header I know we don't have much for our own commits here but we should remain consistent

<commit summary>

<CIQ HEADER, jira number here>

<Commit Body>

Otherwise looks good

At a former employer the tickets went at the bottom and I keep reverting to that. Some day I'll get it :)

LE-2787

These are the configs synced from the corresponding dist-git
LE-2786

Use the remaining unversioned config appropriate for your
architecture (ie kernel-x86_64.config).  These are synced with
the corresponding dist-git config files.
@bmastbergen bmastbergen force-pushed the bmastbergen_ciqlts8_6/configs branch from 54c6ace to bfb204c Compare April 17, 2025 21:00
@bmastbergen
Copy link
Collaborator Author

Could you change this:

build-check: Use unversioned config 

to

github actions: build-check use unversioned config 

also this is silly but the header check we have is like the following, could you put both commits in to that format. https://github.com/ctrliq/kernel-src-tree/wiki#commit-message-header I know we don't have much for our own commits here but we should remain consistent

<commit summary>

<CIQ HEADER, jira number here>

<Commit Body>

Otherwise looks good

At a former employer the tickets went at the bottom and I keep reverting to that. Some day I'll get it :)

Commit msgs updated.

Copy link
Collaborator

@PlaidCat PlaidCat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link

@thefossguy-ciq thefossguy-ciq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚤

@bmastbergen bmastbergen merged commit 00366e2 into ciqlts8_6 Apr 18, 2025
2 checks passed
@bmastbergen bmastbergen deleted the bmastbergen_ciqlts8_6/configs branch April 18, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants