Skip to content

Fix #130 and #114 -- removing tabs error #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stefanuros wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #130 and #114 -- removing tabs error #131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/TabList.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,15 @@ export default class TabListComponent extends React.Component<Props, State> {

// $FlowFixMe
scrollToIndex(index: number, rectSide: 'left' | 'right') {
// Scroll to the last element if the index is out of bounds
if(index > this.tabRefs.length - 1) {
index = this.tabRefs.length - 1;
}
// Cancel scrolling if there are no tabs
else if(this.tabRefs.length <= 0) {
return;
}

const tabOffset = this.getTabNode(this.tabRefs[index]).getBoundingClientRect();
const containerOffset = this.listContainer.getBoundingClientRect();
// Cancel scrolling if the tab is visible
Expand Down