Skip to content

perf(schema-compiler): Introduce compiledJinjaCache #9950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 16, 2025
+29 −13
Merged

perf(schema-compiler): Introduce compiledJinjaCache #9950

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4311b5a
reuse yaml transpilation flow for jinja files
KSDaemon Sep 4, 2025
7e5ffd7
remove perf logging
KSDaemon Sep 5, 2025
6987d42
introduce compiledJinjaCache
KSDaemon Sep 8, 2025
92b20fa
add a comment
KSDaemon Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 26 additions & 13 deletions packages/cubejs-schema-compiler/src/compiler/DataSchemaCompiler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ export type DataSchemaCompilerOptions = {
allowNodeRequire?: boolean;
compiledScriptCache: LRUCache<string, vm.Script>;
compiledYamlCache: LRUCache<string, string>;
compiledJinjaCache: LRUCache<string, string>;
};

export type TranspileOptions = {
Expand Down Expand Up @@ -166,6 +167,8 @@ export class DataSchemaCompiler {

private readonly compiledYamlCache: LRUCache<string, string>;

private readonly compiledJinjaCache: LRUCache<string, string>;

private compileV8ContextCache: vm.Context | null = null;

// FIXME: Is public only because of tests, should be private
Expand Down Expand Up @@ -200,6 +203,7 @@ export class DataSchemaCompiler {
this.compilerId = options.compilerId || 'default';
this.compiledScriptCache = options.compiledScriptCache;
this.compiledYamlCache = options.compiledYamlCache;
this.compiledJinjaCache = options.compiledJinjaCache;
}

public compileObjects(compileServices: CompilerInterface[], objects, errorsReport: ErrorReporter) {
Expand Down Expand Up @@ -689,6 +693,7 @@ export class DataSchemaCompiler {
errorsReport.exitFile();

const content = babelGenerator(ast, {}, file.content).code;

return { ...file, content };
}
} catch (e: any) {
Expand Down Expand Up @@ -762,20 +767,26 @@ export class DataSchemaCompiler {
private async transpileJinjaFile(
file: FileContent,
errorsReport: ErrorReporter,
{ cubeNames, cubeSymbols, contextSymbols, transpilerNames, compilerId, stage }: TranspileOptions
options: TranspileOptions
): Promise<(FileContent | undefined)> {
// if (getEnv('transpilationNative')) {
//
// } else if (getEnv('transpilationWorkerThreads')) {
//
// } else {
return this.yamlCompiler.compileYamlWithJinjaFile(
file,
errorsReport,
this.standalone ? {} : this.cloneCompileContextWithGetterAlias(this.compileContext),
this.pythonContext!
);
// }
const cacheKey = crypto.createHash('md5').update(JSON.stringify(file.content)).digest('hex');

let renderedFileContent: string;

if (this.compiledJinjaCache.has(cacheKey)) {
renderedFileContent = this.compiledJinjaCache.get(cacheKey)!;
} else {
const renderedFile = await this.yamlCompiler.renderTemplate(
file,
this.standalone ? {} : this.cloneCompileContextWithGetterAlias(this.compileContext),
this.pythonContext!
);
renderedFileContent = renderedFile.content;

this.compiledJinjaCache.set(cacheKey, renderedFileContent);
}

return this.transpileYamlFile({ ...file, content: renderedFileContent }, errorsReport, options);
}

public withQuery(query, fn) {
Expand Down Expand Up @@ -830,6 +841,8 @@ export class DataSchemaCompiler {

compiledFiles[file.fileName] = true;

// As now all types of files are transpiled to JS,
// we just call JS compiler for all of them
this.compileJsFile(file, errorsReport, { doSyntaxCheck });
}

Expand Down
3 changes: 3 additions & 0 deletions packages/cubejs-schema-compiler/src/compiler/PrepareCompiler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ export type PrepareCompilerOptions = {
adapter?: string;
compiledScriptCache?: LRUCache<string, vm.Script>;
compiledYamlCache?: LRUCache<string, string>;
compiledJinjaCache?: LRUCache<string, string>;
};

export interface CompilerInterface {
Expand All @@ -61,6 +62,7 @@ export const prepareCompiler = (repo: SchemaFileRepository, options: PrepareComp

const compiledScriptCache = options.compiledScriptCache || new LRUCache<string, vm.Script>({ max: 250 });
const compiledYamlCache = options.compiledYamlCache || new LRUCache<string, string>({ max: 250 });
const compiledJinjaCache = options.compiledJinjaCache || new LRUCache<string, string>({ max: 250 });

const transpilers: TranspilerInterface[] = [
new ValidationTranspiler(),
Expand All @@ -82,6 +84,7 @@ export const prepareCompiler = (repo: SchemaFileRepository, options: PrepareComp
viewCompilationGate,
compiledScriptCache,
compiledYamlCache,
compiledJinjaCache,
viewCompilers: [viewCompiler],
cubeCompilers: [cubeEvaluator, joinGraph, metaTransformer],
contextCompilers: [contextEvaluator],
Expand Down
Loading