-
-
Notifications
You must be signed in to change notification settings - Fork 162
Improve appveyor build - Cucumber part #619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
There are a couple more commits on #505 that I haven't added yet. |
962157e to
1b466e7
Compare
1b466e7 to
3d13025
Compare
e930758 to
6e4c51a
Compare
f898d0d to
e1f44cf
Compare
e1f44cf to
08a250a
Compare
Contributor
|
@mvz if we can work towards deleting / tidying up portions of this I'll commit to supporting getting this merged so we can work towards a windows build soon |
08a250a to
08e5de3
Compare
* Test all behavior in the specs * Leave simple scenario as documentation * Simplify implementation * Render correct path in failure message * Provide separate scenarios for Windows and Unix
* Use existing commands instead of non-portable bash scripts * Use timeout command if sleep is not available
08e5de3 to
87191ff
Compare
Contributor
Author
|
Closing in favor of #894. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Cucumber part of #505.
Details
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: