Skip to content

fix: support asio 1.33 #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2025
Merged

Conversation

shirzartenwer
Copy link
Contributor

@shirzartenwer shirzartenwer commented Jun 13, 2025

Asio changed io_serviceto io_context since 1.33

Summary

Since Asio 1.33, io_service is changed to io_context , so this change is needed to support newer asio version.

Details

Changed the code where io_service is used to io_context. Tested this bug exists by first introducing a flag that made the build fail in this #311

Motivation and Context

How Has This Been Tested?

cmake --build build --target test has been run succesfully, so all the unit test is done.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • It is my own work, its copyright is implicitly assigned to the project and no substantial part of it has been copied from other sources (including Stack Overflow). In rare occasions this is acceptable, like in CMake modules where the original copyright information should be kept.
  • I'm using the same code standards as the existing code (indentation, spacing, variable naming, ...).
  • I've added tests for my code.
  • I have verified whether my change requires changes to the documentation
  • My change either requires no documentation change or I've updated the documentation accordingly.
  • My branch has been rebased to main, keeping only relevant commits.

@shirzartenwer shirzartenwer marked this pull request as draft June 13, 2025 11:46
@shirzartenwer shirzartenwer marked this pull request as ready for review June 13, 2025 13:43
@ursfassler ursfassler merged commit c5c4200 into cucumber:main Jun 13, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants