This repository was archived by the owner on Nov 9, 2022. It is now read-only.
Rename TokenScanners pointer to the deleter in order to allow use with C++
#13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llow use with C++
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
deleteis a keyword in C++, the current version of the header cannot be used in a C++ project. However, both the readme as well as the conditionally compiledextern "C"part in the header suggest that the author intended this library to be usable from C++ as is.Since this is an API break I'm not sure if this is ok, but afaict users of the library aren't supposed to use the function pointer directly and are encouraged to use
TokenScanner_deleteinstead.