Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme/class-diagram): add lacking rule relation #342

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

binhtran432k
Copy link
Member

🤔 What's changed?

Add lacking relation between Rule and Tag in Class Diagram

⚡️ What's your motivation?

While developing a Tree-sitter parser for gherkin, I've just realized that the relationship between Rule and Tag is lacking

🏷️ What kind of change is this?

  • 📖 Documentation (improvements without changing code)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@binhtran432k binhtran432k self-assigned this Jan 2, 2025
@kieran-ryan kieran-ryan self-requested a review January 2, 2025 19:39
Copy link
Member

@kieran-ryan kieran-ryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @binhtran432k!

@kieran-ryan kieran-ryan merged commit dbad965 into main Jan 2, 2025
1 check passed
@kieran-ryan kieran-ryan deleted the docs/fix-class-diagram branch January 2, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants