Template parameters can have blank Default.

cultureamp · Feb 22, 2018 · 7c75d26 · 7c75d26
1 parent 187e3de
commit 7c75d26
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/main.go b/main.go
@@ -30,9 +30,7 @@ type ParameterItem struct {
 }
 
 type ParsedParameterSpec struct {
-	Type        string `yaml:"Type"`
-	Description string `yaml:"Description"`
-	Default     string `yaml:"Default"`
+	Default *string `yaml:"Default",omitempty`
 }
 
 type ParsedTemplate struct {
@@ -109,7 +107,7 @@ func getJsonForInput(input *Input) ([]byte, error) {
 
 	specs := make(map[string]ParameterSpec)
 	for name, parsed := range t.Parameters {
-		specs[name] = ParameterSpec{Name: name, HasDefault: parsed.Default != ""}
+		specs[name] = ParameterSpec{Name: name, HasDefault: parsed.Default != nil}
 	}
 
 	if err := validateParameters(input.Parameters, specs); err != nil {

diff --git a/main_test.go b/main_test.go
@@ -109,6 +109,15 @@ func TestDeployScenario(t *testing.T) {
 	}
 }
 
+func TestBlankDefault(t *testing.T) {
+	input := &Input{
+		TemplateBody:   []byte("Parameters:\n  Foo:\n    Default: \"\"\n"),
+		AcceptDefaults: true,
+	}
+	actual := mustGetParameterItems(t, input)
+	assert.Equal(t, 0, len(actual))
+}
+
 func mustGetParameterItems(t *testing.T, input *Input) []ParameterItem {
 	j, err := getJsonForInput(input)
 	require.NoError(t, err)