[ESR-2405]-Restore focus to trigger button when pressing Escape - #6542
Open
seany-amp wants to merge 3 commits into
Open
[ESR-2405]-Restore focus to trigger button when pressing Escape#6542seany-amp wants to merge 3 commits into
seany-amp wants to merge 3 commits into
Conversation
🦋 Changeset detectedLatest commit: 150aa32 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When pressing Escape to close a Menu dropdown (e.g., the Export button in TitleBlock), focus was being lost instead of returning to the trigger button. This is an accessibility
issue as keyboard users lose their place in the page.
Related ticket: Export button lost focus on hitting the Esc key
What
The root cause was that the returnFocus callback in MenuDropdown was calling focus() on referenceElement, which is a wrapper
focusable button.
Changes:
Before: Focus lost when pressing Escape
Screen.Recording.2026-03-25.at.5.16.42.pm.1.mov
After: Focus returns to the trigger button
Screen.Recording.2026-04-02.at.2.00.13.pm.mov