WIP: feat: Make top strip of title block opt in sticky - #6606
Open
ryanseddon wants to merge 9 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: dcd5f20 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
ryanseddon
force-pushed
the
ryan/KZN-3981/sticky-header
branch
2 times, most recently
from
April 21, 2026 05:42
f3b93e3 to
a2089c8
Compare
Opt-in stickyTopStripWithinContainer prop to make Titleblock top row element stick when TB is scrolled out of viewport.
The sticky top strip offset is now driven by the --app-chrome-sticky-offset CSS custom property (set by the app chrome in the unified-home repo), falling back to the 72px navigation bar height when unset. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Kitty-Al
force-pushed
the
ryan/KZN-3981/sticky-header
branch
from
July 6, 2026 04:54
1023681 to
af6eb26
Compare
Add a story showing a GlobalNotification banner sticking above a sticky TitleBlock, following the additive `--titleblock-sticky-offset` pattern. Add a fake AppChrome nav to the existing sticky scrollable story, and make both the fake nav and `--app-chrome-sticky-offset` collapse below 1080px to match AppChrome's hamburger breakpoint. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- Rename `stickyTopStripWithinContainer` prop (and its CSS class) to `sticky` - Add JSDoc describing the sticky offset contract - Fix `length-zero-no-unit` (0px -> 0) in the sticky top calc - Clarify the changeset description Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Remove `sticky: true` from meta.args so non-sticky stories no longer render in display:contents sticky mode; the two sticky demos set it locally. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Replace hex colours in the sticky story fixtures with token vars: --color-white, --color-purple-800 (fake nav), --border-solid-border-color. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses position sticky by setting titleblock container to display: contents this might break stuff, and be an a11y issue.
Testing is needed
Cursorful.Video.mp4
Important: Request PR reviews on Slack
Please reach out to the design system team on Slack in
#help_design_systemfor PR reviews. GitHub notifications (e.g. from tagging a person) are not actively monitored.Why
What