fix: only notify Slack when a publish was attempted [agent-managed]

[ckychris]

Objective

Merging without a changeset currently posts "Publishing failed" to Slack, even when nothing was meant to publish (renovate config, workflow files). Split the notify job in two: post on an actual publish, post on an actual version job failure, and stay quiet otherwise.

Extracted from #7019 (left open for the tarball-check discussion), cut back to the shape Ryan suggested in thread.

[pip-the-concierge]

🛎️ Concierge

• PR Review — AI-powered code review — ✅ Complete

  Run #10154 — ✅ 4m 18s

  Metric	Value
  Duration	4m 18s
  Model	Opus
  Turns	20
  Tokens	39,204

[changeset-bot]

⚠️ No Changeset found

Latest commit: 5050f39

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

✨ Here is your branch preview! ✨

• Storybook

Last updated for commit 5050f39: fix: only notify Slack when a publish was actually attempted

[pip-the-concierge-via-chinmina]

Overview

This PR fixes a false-positive Slack notification in the changeset publish workflow. Previously, merging without a changeset (e.g. Renovate config or workflow file changes) would trigger a "Publishing failed" message because the old notify-slack job's condition (hasChangesets == 'false') was true whenever no changesets existed — regardless of whether a publish was actually attempted. The fix splits the single notification job into two: notify-slack-success (fires only when packages are actually published) and notify-slack-failure (fires only when the version job genuinely fails). This is a clean, minimal, and correct fix.

For reviewers

Entry point: Start at .github/workflows/changeset.yaml — the single changed file splits one conditional job into two independent jobs.

Key questions:

• Is the always() guard on notify-slack-failure correct? It ensures the job runs even when version fails (GitHub Actions default skips dependents), while result == 'failure' excludes cancelled runs. Verify this matches the team's intent (cancelled workflows stay silent).
• Should the success message remain generic ("Packages have been published") or include the publishedPackages output for richer context, as the old job had access to?

---

generated using the pr-review workflow in 20 turns
give feedback with reactions 👍 👎