Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove catboost #46

Closed
wants to merge 2 commits into from
Closed

Remove catboost #46

wants to merge 2 commits into from

Conversation

topepo
Copy link
Collaborator

@topepo topepo commented Jul 6, 2021

Related to #45

It would be good for someone to make a release or branch before merging this so that we can recycle the previous work if they get catboost on CRAN

dfalbel added a commit that referenced this pull request Jul 9, 2021
@dfalbel
Copy link
Member

dfalbel commented Jul 10, 2021

I am up for submitting treesnip to CRAN by removing catboost. Currently we are observing a crash on windows when lightgbm is loaded together with parsnip though (see microsoft/LightGBM#4464) . I think we should probably get that fixed before releasing treesnip.

@eitsupi
Copy link

eitsupi commented Nov 5, 2021

microsoft/LightGBM#4464 seems to have been resolved. Any update?

@dfalbel
Copy link
Member

dfalbel commented Nov 6, 2021

Hi @eitsupi

Yes, planning to work on this soon. LightGBM itroduced a few breaking changes in the newer version that we should fix before releasing (see #50).

Let us know if you are interested in working in this issue.

@dfalbel
Copy link
Member

dfalbel commented Dec 26, 2021

Thanks @topepo ! Favoured #55 instead

@dfalbel dfalbel closed this Dec 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants