Skip to content

Cursorless scope side bar#1942

Merged
pokey merged 2 commits into
mainfrom
pokey/cursorless-scope-side-bar
Oct 30, 2023
Merged

Cursorless scope side bar#1942
pokey merged 2 commits into
mainfrom
pokey/cursorless-scope-side-bar

Conversation

@pokey

@pokey pokey commented Oct 12, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Checklist

  • [-] I have added tests (see comment below)
  • Add descriptions to section headings (eg present, not present, etc)
  • File issue about using lang icons for lang-specific scopes
  • I have updated the docs and cheatsheet
  • I have not broken the cheatsheet
  • File issue for showing scopes touching, as well as equal to, selection
  • Checkboxes from original Scope support tree view #1663

This was referenced Oct 12, 2023
Merged
Merged
@pokey
pokey force-pushed the pokey/cursorless-scope-side-bar branch from d0fcf1b to d5f310c Compare October 12, 2023 17:41
@pokey
pokey force-pushed the pokey/scope-info-provider branch from c9fe1a3 to 3b17e39 Compare October 12, 2023 17:41
github-merge-queue Bot pushed a commit that referenced this pull request Oct 13, 2023
@pokey
Expand scope visualizer api (#1946)
47cc724 
- Required by #1942 to be able to tell which scope is currently being
visualized to highlight it in the sidebar

## Checklist

- [ ] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [ ] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [ ] I have not broken the cheatsheet
@pokey
pokey force-pushed the pokey/cursorless-scope-side-bar branch 2 times, most recently from c815e0d to 8cae134 Compare October 16, 2023 15:29
@pokey
pokey force-pushed the pokey/scope-info-provider branch from 887c7df to 82a8ef5 Compare October 16, 2023 15:29
@pokey
pokey force-pushed the pokey/cursorless-scope-side-bar branch from 9b6a204 to abff9fb Compare October 16, 2023 15:47
@pokey
pokey force-pushed the pokey/scope-info-provider branch from ceaf377 to 1c6435b Compare October 16, 2023 16:17
@pokey
pokey force-pushed the pokey/cursorless-scope-side-bar branch 2 times, most recently from c0a93d1 to 87cb21e Compare October 17, 2023 13:55
@pokey
pokey force-pushed the pokey/scope-info-provider branch from 3c5d883 to 962f921 Compare October 17, 2023 14:11
@pokey
pokey force-pushed the pokey/cursorless-scope-side-bar branch from 6c86b5a to 103f385 Compare October 17, 2023 14:11
@pokey
pokey force-pushed the pokey/scope-info-provider branch from d80a73f to 9f61dd8 Compare October 18, 2023 15:08
@pokey
pokey force-pushed the pokey/cursorless-scope-side-bar branch 2 times, most recently from 1077cbd to b826f3e Compare October 18, 2023 15:17
@pokey
pokey force-pushed the pokey/scope-info-provider branch 2 times, most recently from 709fb57 to d995f40 Compare October 18, 2023 15:57
@pokey
pokey force-pushed the pokey/cursorless-scope-side-bar branch from b826f3e to 3e8b231 Compare October 18, 2023 15:57
pokey
pokey commented Oct 19, 2023
View reviewed changes
Comment thread packages/cursorless-vscode/src/ScopeTreeProvider.ts Outdated
@pokey
pokey force-pushed the pokey/cursorless-scope-side-bar branch from 3e8b231 to ebd6923 Compare October 20, 2023 12:45
@pokey
pokey force-pushed the pokey/scope-info-provider branch from d995f40 to a977bf0 Compare October 20, 2023 12:45
@pokey
pokey force-pushed the pokey/cursorless-scope-side-bar branch 2 times, most recently from f92a480 to 6e49a1c Compare October 20, 2023 13:07
@pokey
pokey force-pushed the pokey/scope-info-provider branch from 49c3931 to 2f3d43e Compare October 20, 2023 13:07
@pokey
pokey force-pushed the pokey/cursorless-scope-side-bar branch from fce6e07 to 3a4afaa Compare October 20, 2023 13:18
@pokey
pokey force-pushed the pokey/scope-info-provider branch from 2f3d43e to 156ff94 Compare October 20, 2023 13:18
@pokey
pokey force-pushed the pokey/cursorless-scope-side-bar branch 2 times, most recently from d90b78a to 9f0780d Compare October 20, 2023 13:40
@pokey
pokey force-pushed the pokey/scope-info-provider branch 2 times, most recently from 19e052b to 8e36dcb Compare October 25, 2023 10:35
@pokey
pokey force-pushed the pokey/cursorless-scope-side-bar branch 2 times, most recently from 18a68d1 to 9d022b8 Compare October 25, 2023 10:39
@pokey
pokey force-pushed the pokey/scope-info-provider branch 2 times, most recently from 4e411b2 to d3976ea Compare October 25, 2023 11:14
@pokey
pokey force-pushed the pokey/cursorless-scope-side-bar branch 2 times, most recently from 31c0e17 to 4eca605 Compare October 25, 2023 12:11
@pokey
pokey force-pushed the pokey/scope-info-provider branch from d3976ea to 0a744f1 Compare October 25, 2023 12:11
@pokey
pokey force-pushed the pokey/cursorless-scope-side-bar branch from 4eca605 to 7003986 Compare October 25, 2023 12:28
@pokey
pokey force-pushed the pokey/scope-info-provider branch from 0a744f1 to 376e937 Compare October 25, 2023 12:28
@pokey
pokey force-pushed the pokey/cursorless-scope-side-bar branch from 7003986 to ebecf13 Compare October 25, 2023 12:33
@pokey
pokey force-pushed the pokey/scope-info-provider branch from a84251c to 3f931dc Compare October 25, 2023 12:49
@pokey
pokey force-pushed the pokey/cursorless-scope-side-bar branch from ebecf13 to 33a3510 Compare October 25, 2023 12:49
@pokey
pokey force-pushed the pokey/scope-info-provider branch from 3f931dc to f456415 Compare October 25, 2023 12:51
@pokey
pokey force-pushed the pokey/cursorless-scope-side-bar branch 2 times, most recently from 0a60ac6 to b7e285e Compare October 25, 2023 12:52
@pokey
pokey force-pushed the pokey/scope-info-provider branch from f456415 to 41f18a8 Compare October 25, 2023 12:52
@pokey
pokey force-pushed the pokey/cursorless-scope-side-bar branch 2 times, most recently from c3f31fb to 7a38dde Compare October 25, 2023 13:13
@pokey
pokey force-pushed the pokey/scope-info-provider branch from 43fd688 to 796149c Compare October 25, 2023 13:13
pokey
pokey commented Oct 26, 2023
View reviewed changes
Comment thread packages/common/src/cursorlessCommandIds.ts
This was referenced Oct 27, 2023
Open
Closed
@pokey

pokey commented Oct 27, 2023

Copy link
Copy Markdown
Member Author

Ok this one is also good to go @AndreasArvidsson; will need to merge in behind a couple others tho so please don't merge

@pokey

pokey commented Oct 27, 2023

Copy link
Copy Markdown
Member Author

I didn't add tests for this one, because most of the hard logic is tested in #1941. This one is trying hard to be pure presentation, and unfortunately testing it is quite hard until we have a setup where we delay initialisation of the extension to allow test harness to be put in place

@pokey pokey mentioned this pull request May 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndreasArvidsson AndreasArvidsson AndreasArvidsson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pokey @AndreasArvidsson