Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for elisp #48

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add support for elisp #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# For generating .wasm files for parsers
# See https://www.npmjs.com/package/web-tree-sitter
LANGUAGES = agda bash c c-sharp clojure cpp css elm go haskell html java javascript json kotlin latex markdown php python query ruby rust scala scss sparql talon tsx typescript yaml
LANGUAGES = agda bash c c-sharp clojure cpp css elisp elm go haskell html java javascript json kotlin latex markdown php python query ruby rust scala scss sparql talon tsx typescript yaml


# NOTE: Update the version number in the filepath for web-tree-sitter in package.json,
Expand Down
4 changes: 3 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
"onLanguage:cpp",
"onLanguage:css",
"onLanguage:csharp",
"onLanguage:elisp",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"elisp" isn't a known language identifier: https://code.visualstudio.com/docs/languages/identifiers#_known-language-identifiers. I checked the marketplace and there seems to be one extension that labels it as "lisp" https://github.com/mattn/vscode-lisp/blob/master/package.json#L26, so I'm not sure how to proceed here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh. Looks like there's no formal identifier specified by lsp either 🤔

Fwiw you will need to install a VSCode extension that registers that language id in order for this to actually work. So I'd just pick a VSCode extension that you want to use with elisp, and then use whatever language identifier that extension uses

If there is no such extension, you could either:

  • Create your own simple extension that just registers the language id and associates it with a file extension
  • Add a contributes.languages block to this extension. Slightly mixed feelings about that, as it feels out of scope for this extension, but maybe the simplest path forward

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just wanted to follow up

"onLanguage:elm",
"onLanguage:go",
"onLanguage:haskell",
Expand Down Expand Up @@ -90,6 +91,7 @@
"tree-sitter-cli": "^0.20.1",
"tree-sitter-clojure": "github:sogaiu/tree-sitter-clojure#master",
"tree-sitter-cpp": "^0.19.0",
"tree-sitter-elisp": "^1.2.0",
"@elm-tooling/tree-sitter-elm": "github:elm-tooling/tree-sitter-elm#0aecfbf69f0c9bcdfada0f6f2c5398235c23949f",
"tree-sitter-go": "^0.19.0",
"tree-sitter-haskell": "github:tree-sitter/tree-sitter-haskell#d6ccd2d9c40bdec29fee0027ef04fe5ff1ae4ceb",
Expand Down Expand Up @@ -124,4 +126,4 @@
"bundledDependencies": [
"web-tree-sitter"
]
}
}
1 change: 1 addition & 0 deletions src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ const languages: {
cpp: { module: "tree-sitter-cpp" },
csharp: { module: "tree-sitter-c-sharp" },
css: { module: "tree-sitter-css" },
elisp: { module: "tree-sitter-elisp" },
elm: { module: "tree-sitter-elm" },
go: { module: "tree-sitter-go" },
haskell: { module: "tree-sitter-haskell" },
Expand Down