Skip to content

feat: add manage soft liquidation card #1321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat: add manage soft liquidation card #1321

wants to merge 2 commits into from

Conversation

0xAlunara
Copy link
Collaborator

Draft PR to share codebase of the obvious WIP. Most likely functionality will be split off into separate PRs.

@vercel Vercel
Copy link

vercel bot commented Sep 2, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
curve-dapp Ready Ready Preview Comment Sep 18, 2025 9:30pm
curve-dapp-storybook Ready Ready Preview Comment Sep 18, 2025 9:30pm

@0xAlunara 0xAlunara marked this pull request as draft September 2, 2025 13:48
DanielSchiavini
DanielSchiavini reviewed Sep 2, 2025
View reviewed changes
apps/main/src/llamalend/hooks/mutations/useClosePosition.ts Outdated
import { notify } from '@ui-kit/features/connect-wallet'
import { useUserProfileStore } from '@ui-kit/features/user-profile'

const handlers = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could maybe also just pass "Closing position" and "Position closed" to useLlammaMutation? 🤔
Btw these are missing translation

apps/main/src/llamalend/hooks/mutations/useLlammaMutation.ts

/**
* Custom hook for handling llamma-related mutations with automatic wallet and API validation
* Could argue for a refactor to validate with vest like we do for queries, but I'd rather keep
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have some good example on how to connect vest with react-hook-form and react-query

curve-frontend/apps/main/src/dex/features/add-gauge-reward-token/ui/AddRewardToken.tsx

Lines 31 to 50 in 5e57f7b

const methods = useForm<AddRewardFormValues>({
...formDefaultOptions,
resolver: vestResolver(addGaugeRewardTokenValidationSuite),
defaultValues: {
rewardTokenId: zeroAddress,
distributorId: signerAddress ?? zeroAddress,
},
})
const {
setError,
formState: { isSubmitting },
handleSubmit,
} = methods
const {
mutate: addRewardToken,
isPending: isPendingAddRewardToken,
isSuccess: isSuccessAddRewardToken,
data: addRewardTokenData,
} = useAddRewardToken({ chainId, poolId })

We can discuss whether react-hook-form is a good idea though, in my own site I'm real happy with Formik

DanielSchiavini
DanielSchiavini reviewed Sep 10, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielSchiavini DanielSchiavini DanielSchiavini left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xAlunara @DanielSchiavini