feat: use mint market controller address in url instead of id #1424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
pilotvietnam
approved these changes
Sep 24, 2025
0xtutti
approved these changes
Sep 24, 2025
DanielSchiavini
approved these changes
Sep 24, 2025
| component: CreateLoan, | ||
| head: ({ params }) => ({ | ||
| meta: [{ title: `Create - ${params.collateralId} - Curve` }], | ||
| meta: [{ title: `Create - ${params.market} - Curve` }], |
There was a problem hiding this comment.
we'll need to fix the title in a separate task
DanielSchiavini
merged commit fc7f25d
into
refactor/collateral-zustand-to-tanstack
13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1423
Honestly the feature was already supported with #1423 where we decided to use the
useMintMarkethook, which also maps controller addresses to mint market templates.This PR basically just renames some variables such that it's more consistent with lending markets. And it changes the URL for mint market rows in the llamalend markets table.