test: trigger all 5 live-notification campaigns from sample app#735
Draft
mahmoud-elmorabea wants to merge 1 commit into
Draft
test: trigger all 5 live-notification campaigns from sample app#735mahmoud-elmorabea wants to merge 1 commit into
mahmoud-elmorabea wants to merge 1 commit into
Conversation
…cation demo Testing-only helper: fires the campaign trigger event once per activity type so the backend campaign drives all five live-notification flows at once, each with a unique timestamp/activity_id. Refactors getStepCount/sendPush into template-parameterized stepCountFor/sendFor + a shared fireCampaign() helper. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/live-notifications #735 +/- ##
================================================================
- Coverage 66.80% 66.74% -0.06%
Complexity 1041 1041
================================================================
Files 177 177
Lines 5711 5711
Branches 786 786
================================================================
- Hits 3815 3812 -3
Misses 1607 1607
- Partials 289 292 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
|
📏 SDK Binary Size Comparison ReportNo changes detected in SDK binary size ✅ |
|
Build available to test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing only — do not merge. Branched off
feature/live-notificationsto exercise the live-notification flows end-to-end from the java_layout sample.What
Adds a "Trigger all 5 via campaign" button to the live-notification demo. It fires the campaign trigger event once per activity type (each with a unique timestamp → unique Liquid-built
activity_id) so a single tap drives all five backend-campaign flows at once.Refactors the existing single-template paths so they can be reused per type:
getStepCount()→stepCountFor(template)sendPush()→sendFor(template, event, step)fireCampaign(activityType, timestamp)helper used by both the single and "all" triggers.Why
Manual verification of the rebased
feature/live-notificationsstack — lets one tap kick off every template variant instead of cycling the dropdown five times.🤖 Generated with Claude Code