fix(sample): accept localhost host:port in internal settings URL validation#760
Draft
mahmoud-elmorabea wants to merge 3 commits into
Draft
fix(sample): accept localhost host:port in internal settings URL validation#760mahmoud-elmorabea wants to merge 3 commits into
mahmoud-elmorabea wants to merge 3 commits into
Conversation
…dation Uri.parse treats the host in "localhost:8080" as a scheme, so the internal settings validator rejected localhost (and IP) host:port values. Detect a real scheme via "://" instead of getScheme(). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #760 +/- ##
============================================
- Coverage 69.07% 68.49% -0.58%
- Complexity 838 898 +60
============================================
Files 149 159 +10
Lines 4601 4920 +319
Branches 628 661 +33
============================================
+ Hits 3178 3370 +192
- Misses 1189 1304 +115
- Partials 234 246 +12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
|
📏 SDK Binary Size Comparison Report
|
|
Build available to test |
Both delivery paths hard-coded "https://" + host. Respect an explicit http://|https:// scheme on the configured api/cdn host (default https when absent) so non-production http endpoints can be used: - core CustomerIOHttpClient uses the host as-is when it carries a scheme - a SchemeAwareRequestFactory collapses Segment's forced https:// when the host already specifies one (covers event upload + settings fetch) - sample internal settings validation accepts an optional http(s):// prefix Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
|
…onfig Confirms updateAnalyticsConfig installs the factory on Configuration (Segment builds its HTTPClient from configuration.requestFactory) and that the doubled scheme collapses to the configured one. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the internal settings screen rejecting
localhost:8080(and IP)host:portvalues as invalid API/CDN host URLs.Uri.parsetreats the host before the colon as a scheme, so the validator flagged it; we now detect a real scheme via://instead.🤖 Generated with Claude Code