chore: Prevent GoogleService-info.plist from being double copied#225
Merged
mahmoud-elmorabea merged 3 commits intoMar 13, 2025
Merged
Conversation
Shahroz16
approved these changes
Mar 12, 2025
Shahroz16
left a comment
Shahroz16
left a comment
Contributor
There was a problem hiding this comment.
After a team discussion, we are going forward with this approach until we find a better one.
mrehan27
approved these changes
Mar 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ReactNative Firebase dependency requires
GoogleService-info.plistto be added to the iOS project.RN Firebase doesn't check if the file already exists before adding it to the project. Since we cannot depend on customers having ReactNative Firebase to copy the file. Our plugin copies the file.
This PR adds a check at the path where ReactNative Firebase copies the file first before copying it.