test(inbox): restore MessagingInApp AutoMockable inbox mocks#1142
Draft
mahmoud-elmorabea wants to merge 1 commit into
Draft
test(inbox): restore MessagingInApp AutoMockable inbox mocks#1142mahmoud-elmorabea wants to merge 1 commit into
mahmoud-elmorabea wants to merge 1 commit into
Conversation
Rebasing feat/overlay-inbox onto main required resolving a conflict in the Sourcery-generated Tests/Mocks/MessagingInApp/AutoMockable.generated.swift (main refactored mocks to Synchronized wrappers). The conflict was resolved by taking main's regenerated file, which dropped the branch's inbox additions and broke the Tests target: * MessagingInAppInstanceMock no longer conformed (missing setInboxEventListener) * InboxEventListenerMock (used by NotificationInboxTest) was gone entirely Restore both, matching the generator output (setInboxEventListener mirrors the sibling setEventListener; InboxEventListenerMock is the Sourcery-generated class for the new InboxEventListener protocol). Sourcery isn't available in this environment; a future `make generate` will reconcile styling. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. |
SDK binary size reports 📊SDK binary size of this PRSDK binary size diff report vs. main branch |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/overlay-inbox #1142 +/- ##
=====================================================
Coverage ? 68.44%
=====================================================
Files ? 248
Lines ? 13007
Branches ? 0
=====================================================
Hits ? 8902
Misses ? 4105
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
test / automated-testsfailure onfeat/overlay-inboxafter it was rebased onto latestmain.Root cause: the rebase hit a conflict in the Sourcery-generated
Tests/Mocks/MessagingInApp/AutoMockable.generated.swift(main refactored mocks toSynchronizedwrappers). Resolving it by taking main's regenerated file dropped the branch's inbox mock additions, so theMessagingInAppmock target no longer compiled:MessagingInAppInstanceMockstopped conforming toMessagingInAppInstance— missingsetInboxEventListener(_:)(AutoMockable.generated.swift:1782).InboxEventListenerMock(used byNotificationInboxTest) was gone entirely.Fix: restore both, matching generator output —
setInboxEventListenermirrors the siblingsetEventListener;InboxEventListenerMockis the class Sourcery generates for the newInboxEventListenerprotocol. Test-only change. Sourcery/binnyisn't available in this environment, so a futuremake generatewill reconcile styling with no behavioral change.Draft, targeting
feat/overlay-inbox. Sample-app builds on #1141 already pass; merging this makes the Tests job green too.🤖 Generated with Claude Code