Skip to content

Use windows line endings for windows hosts file #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Novex wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use windows line endings for windows hosts file #65

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e5eaa0
Use windows line endings for windows hosts file
Novex Feb 13, 2015
1ad9b83
nicer syntax
Novex Jun 21, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion libraries/manipulator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,9 @@ def new_content
entries = hostsfile_header
entries += unique_entries.map(&:to_line)
entries << ''
entries.join("\n")
line_ending = "\n"
line_ending = "\r\n" if node['platform_family'] == 'windows'
Copy link

@mburns mburns Jun 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could combine this line (ex. line_ending = node['platform_family'] == 'windows' ? "\r\n" : "\n") so that we don't assign line_ending twice, in the uncommon case.

Copy link
Author

@Novex Novex Jun 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good to me, ruby isn't my first language :)

entries.join(line_ending)
end

# The current sha of the system hostsfile.
Expand Down