Skip to content

feat: Tell how many days an issue has since being opened #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sanlf wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: Tell how many days an issue has since being opened #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion lib/search.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,23 @@ function transform (data) {
url: item.html_url,
assignee: item.assignee,
assignees: item.assignees,
locked: item.locked
locked: item.locked,
daysOpened: diffDate(item.created_at)
})
}, [])

return issues
}

function diffDate (date) {
if (date === undefined) {
return -1
}
const currDate = new Date(Date.now())
const copyDate = new Date(date)
const diff = Math.floor((currDate - copyDate) / (24 * 60 * 60 * 1000))

return diff
}

module.exports = search
20 changes: 16 additions & 4 deletions tests/index.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,15 @@ const options = {
describe('goodFirstIssue', () => {
let items

beforeAll(() => {
// this Date.now() is this date: 2020-06-05T18:49:18.644Z
jest.spyOn(Date, 'now').mockImplementation(() => 1591382958644)
})

afterAll(() => {
jest.clearAllMocks()
})

beforeEach(() => { // set up mock response
items = [{
title: 'fooTitle',
Expand All @@ -19,7 +28,8 @@ describe('goodFirstIssue', () => {
html_url: 'fooHtmlUrl',
assignee: null,
assignees: 'fooAssignees',
locked: false
locked: false,
created_at: '2020-06-01T11:00:00Z'
}]

// "Mock" network requests to the Search API
Expand All @@ -39,12 +49,13 @@ describe('goodFirstIssue', () => {
state: 'fooState',
title: 'fooTitle',
url: 'fooHtmlUrl',
daysOpened: 4
}])
})

it('returns the expected issues from the GitHub organization', async() => {
const actual = await goodFirstIssue('github')

expect(actual).toEqual([{
assignee: null,
assignees: 'fooAssignees',
Expand All @@ -54,7 +65,8 @@ describe('goodFirstIssue', () => {
repo: 'fooRepoUrl',
state: 'fooState',
title: 'fooTitle',
url: 'fooHtmlUrl'
url: 'fooHtmlUrl',
daysOpened: 4
}])
})
})
})
73 changes: 50 additions & 23 deletions tests/search.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,15 @@
let issuesAndPullRequests
let search

beforeAll(() => {
// this Date.now() is this date: 2020-06-05T18:49:18.644Z
jest.spyOn(Date, 'now').mockImplementation(() => 1591382958644)
})

afterAll(() => {
jest.clearAllMocks()
})

beforeEach(() => {
jest.resetModules()
jest.restoreAllMocks()
Expand All @@ -27,7 +36,8 @@ test('should return filtered issues if there is only one page', () => {
html_url: 'fooHtmlUrl',
assignee: null,
assignees: 'fooAssignees',
locked: false
locked: false,
created_at: '2020-06-01T11:00:00Z'
},
{
title: 'barTitle',
Expand All @@ -38,7 +48,8 @@ test('should return filtered issues if there is only one page', () => {
html_url: 'barHtmlUrl',
assignee: 'barAssignee',
assignees: 'barAssignees',
locked: false
locked: false,
created_at: '2020-06-01T11:00:00Z'
},
{
title: 'bazTitle',
Expand All @@ -49,7 +60,8 @@ test('should return filtered issues if there is only one page', () => {
html_url: 'bazHtmlUrl',
assignee: null,
assignees: 'bazAssignees',
locked: true
locked: true,
created_at: '2020-06-01T11:00:00Z'
}
]

Expand All @@ -74,9 +86,10 @@ test('should return filtered issues if there is only one page', () => {
url: 'fooHtmlUrl',
assignee: null,
assignees: 'fooAssignees',
locked: false
locked: false,
daysOpened: 4
}
])
])
})
})

Expand All @@ -91,7 +104,8 @@ test('should return filtered issues if there is more than one page', () => {
html_url: 'fooHtmlUrl',
assignee: null,
assignees: 'fooAssignees',
locked: false
locked: false,
created_at: '2020-06-01T11:00:00Z'
},
{
title: 'barFirstTitle',
Expand All @@ -102,7 +116,8 @@ test('should return filtered issues if there is more than one page', () => {
html_url: 'barHtmlUrl',
assignee: 'barAssignee',
assignees: 'barAssignees',
locked: false
locked: false,
created_at: '2020-06-01T11:00:00Z'
},
{
title: 'bazFirstTitle',
Expand All @@ -113,7 +128,8 @@ test('should return filtered issues if there is more than one page', () => {
html_url: 'bazHtmlUrl',
assignee: null,
assignees: 'bazAssignees',
locked: true
locked: true,
created_at: '2020-06-01T11:00:00Z'
}
]

Expand All @@ -127,7 +143,8 @@ test('should return filtered issues if there is more than one page', () => {
html_url: 'fooHtmlUrl',
assignee: null,
assignees: 'fooAssignees',
locked: false
locked: false,
created_at: '2020-06-01T11:00:00Z'
},
{
title: 'barSecondTitle',
Expand All @@ -138,7 +155,8 @@ test('should return filtered issues if there is more than one page', () => {
html_url: 'barHtmlUrl',
assignee: 'barAssignee',
assignees: 'barAssignees',
locked: false
locked: false,
created_at: '2020-06-01T11:00:00Z'
},
{
title: 'bazSecondTitle',
Expand All @@ -149,7 +167,8 @@ test('should return filtered issues if there is more than one page', () => {
html_url: 'bazHtmlUrl',
assignee: null,
assignees: 'bazAssignees',
locked: true
locked: true,
created_at: '2020-06-01T11:00:00Z'
}
]

Expand All @@ -169,7 +188,7 @@ test('should return filtered issues if there is more than one page', () => {
})

return search({}).then(result => {
expect(issuesAndPullRequests).toHaveBeenCalledTimes(2)
expect(issuesAndPullRequests).toHaveBeenCalledTimes(2)
const searchParams = issuesAndPullRequests.mock.calls[1][0]
expect(searchParams["page"]).toBeLessThanOrEqual(2)
expect(result).toEqual([
Expand All @@ -182,10 +201,11 @@ test('should return filtered issues if there is more than one page', () => {
url: 'fooHtmlUrl',
assignee: null,
assignees: 'fooAssignees',
locked: false
locked: false,
daysOpened: 4
}
])

})
})

Expand All @@ -200,7 +220,8 @@ test('should return filtered issues if there are more than allowed pages', () =>
html_url: 'fooHtmlUrl',
assignee: null,
assignees: 'fooAssignees',
locked: false
locked: false,
created_at: '2020-06-01T11:00:00Z'
},
{
title: 'barFirstTitle',
Expand All @@ -211,7 +232,8 @@ test('should return filtered issues if there are more than allowed pages', () =>
html_url: 'barHtmlUrl',
assignee: 'barAssignee',
assignees: 'barAssignees',
locked: false
locked: false,
created_at: '2020-06-01T11:00:00Z'
},
{
title: 'bazFirstTitle',
Expand All @@ -222,7 +244,8 @@ test('should return filtered issues if there are more than allowed pages', () =>
html_url: 'bazHtmlUrl',
assignee: null,
assignees: 'bazAssignees',
locked: true
locked: true,
created_at: '2020-06-01T11:00:00Z'
}
]

Expand All @@ -236,7 +259,8 @@ test('should return filtered issues if there are more than allowed pages', () =>
html_url: 'fooHtmlUrl',
assignee: null,
assignees: 'fooAssignees',
locked: false
locked: false,
created_at: '2020-06-01T11:00:00Z'
},
{
title: 'barSecondTitle',
Expand All @@ -247,7 +271,8 @@ test('should return filtered issues if there are more than allowed pages', () =>
html_url: 'barHtmlUrl',
assignee: 'barAssignee',
assignees: 'barAssignees',
locked: false
locked: false,
created_at: '2020-06-01T11:00:00Z'
},
{
title: 'bazSecondTitle',
Expand All @@ -258,11 +283,12 @@ test('should return filtered issues if there are more than allowed pages', () =>
html_url: 'bazHtmlUrl',
assignee: null,
assignees: 'bazAssignees',
locked: true
locked: true,
created_at: '2020-06-01T11:00:00Z'
}
]

//set total_count more than allowed_records = 1000
//set total_count more than allowed_records = 1000
const total_count = 57000;

issuesAndPullRequests.mockResolvedValueOnce({
Expand All @@ -278,7 +304,7 @@ test('should return filtered issues if there are more than allowed pages', () =>
})

return search({}).then(result =>{
expect(issuesAndPullRequests).toHaveBeenCalledTimes(2)
expect(issuesAndPullRequests).toHaveBeenCalledTimes(2)
const searchParams = issuesAndPullRequests.mock.calls[1][0]
expect(searchParams["page"]).toBeLessThanOrEqual(34)
expect(result).toEqual([
Expand All @@ -291,7 +317,8 @@ test('should return filtered issues if there are more than allowed pages', () =>
url: 'fooHtmlUrl',
assignee: null,
assignees: 'fooAssignees',
locked: false
locked: false,
daysOpened: 4
}
])
})
Expand Down